From owner-cvs-all Sun Nov 3 14:30: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BE5137B401; Sun, 3 Nov 2002 14:30:06 -0800 (PST) Received: from obsecurity.dyndns.org (adsl-64-165-226-88.dsl.lsan03.pacbell.net [64.165.226.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A90943E42; Sun, 3 Nov 2002 14:30:05 -0800 (PST) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id F02CC66CFB; Sun, 3 Nov 2002 14:30:04 -0800 (PST) Date: Sun, 3 Nov 2002 14:30:04 -0800 From: Kris Kennaway To: Trevor Johnson Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20021103223004.GB25257@xor.obsecurity.org> References: <200211030543.gA35hnMM018389@repoman.freebsd.org> <20021103084715.F95677-100000@blues.jpj.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: <20021103084715.F95677-100000@blues.jpj.net> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 03, 2002 at 09:27:28AM -0500, Trevor Johnson wrote: > > * If the ${COMMENT} file does not exist, use the value of the > > ${PORTCOMMENT} variable instead. This will allow us to incremental= ly > > phase out pkg-comment [1] >=20 > This is not IBM-compatible. IBM cards only have 80 columns. Using 14 of > them for >=20 > PORTCOMMENT=3D"" >=20 > leaves only 66 for the comment itself, unless a continuation card is > used. NetBSD and OpenBSD have chosen the > shorter name COMMENT instead. That leaves 70 columns for the comment. > Our portlint recommends 70 (or fewer columns), so existing ports which > pass portlint are already consistent with the shorter name, but not > necessarily with the longer one. >=20 > Here's a patch. I tested it and it failed "make package" in the same > manner that bsd.port.mk rev. 1.427 does ("pkg_create: only one package > name allowed ('for' extraneous)"). It also failed "make deinstall" in the > same way ("pkg_delete: package 'portlint-2.3.3' doesn't have a prefix"). The problem with using COMMENT is that a number of ports already override it, so this patch breaks them. Kris --qcHopEYAB45HaUaB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE9xaNsWry0BWjoQKURAsPkAJ0UvsNT5tFZPBOnzxwprTwhUk3kzQCgwjng hhyMc+otmqp4vofolhdAhGc= =NzMI -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message