From owner-dev-commits-src-branches@freebsd.org Sat Jul 31 17:28:39 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7949B6616E6 for ; Sat, 31 Jul 2021 17:28:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcWT32WsDz4mLC for ; Sat, 31 Jul 2021 17:28:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2c.google.com with SMTP id d17so6891038qvn.13 for ; Sat, 31 Jul 2021 10:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZVe9EjNfIuGlRbgqt3pyhcHYsK+8Lz9AFbp1LhKyR+k=; b=piOGmEF7OU0+U1xP7YdobbOrI0qM9GAtvJqxBnW4OEz/TXMl5nWnAPIrIeKNp/BecX FNotTmpfcja4jEG2mPbF4Ybjdl+jxyPypunlZwSRIoDqHlnc6/utZfMS9aJOdn0aRsjE l8qINuV0GlwzFuhd5P2kngpp5T5jlplTgvXAeOOIGidnce0rki7nAAOCiRtTcHiR/oTP OG3noM86I1mnOOagvZxFt9beUBd+yy7AVEn4LRk8pI/2vwS+G4coFkGq5dZmlSTHha5d 1hG1yko3sH0a8Qx98lHI+XY8LcfCG3NRNw2jHwi9eItbkYDNuB+weP3NbBsGzWhqz2SQ XI+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZVe9EjNfIuGlRbgqt3pyhcHYsK+8Lz9AFbp1LhKyR+k=; b=YzxtMkK4cJJY64Fk6P0Ykq8KDOd8bwSOMORja4gurj2QnjzHEudbAAL8W+T3jM4syq 5HhqSaQwPNiXVasSe5WHNKl5y85dHHKcrMNx+ffFNkQFKL0v+Z/KZfB49CGNMJPqYWZS 01nctaYrmSUMzTbxTKysWeBnI96xXBDo6E98lIMZ0Agg2lbug0m5HQkkQUfQp0ohgYAx pI7zGl0PH1rxN1UtI4RIes6JpF6YLygbupnQNzagF2C25dmn+lkesLiEO6Ds5PH4Pvo8 5WDBjyXAgbXecmrRqEVK0KVEQFlfoR7u2MU/NmqSQ6zOchLZ18HC9cCGAGJyaaObyetZ BBCw== X-Gm-Message-State: AOAM532HfNIhOQzbLx22rG7gM9XCEPIRPdlloOrkFi8BFgdgkMNfPB+S iqPKHU4nHsL8QXs06526iDhboaP8CY9ZMtt04j372g== X-Google-Smtp-Source: ABdhPJw/Z2CK47hSZJ+9xuPJ8QbULhlx6X9TiWoAaOkU7FmlJj6pbbWK5RfSOaOu33uPbPg13NFaZPwdv+PGxBd7k14= X-Received: by 2002:a05:6214:17cb:: with SMTP id cu11mr8984194qvb.28.1627752513386; Sat, 31 Jul 2021 10:28:33 -0700 (PDT) MIME-Version: 1.0 References: <202107101712.16AHCwoE088447@gitrepo.freebsd.org> <4AD3AB8C-A960-43BE-A89B-5D9C4CD077DD@FreeBSD.org> <8300183E-DD11-4C2F-AE5A-0B6FDE6E9E8F@FreeBSD.org> In-Reply-To: <8300183E-DD11-4C2F-AE5A-0B6FDE6E9E8F@FreeBSD.org> From: Warner Losh Date: Sat, 31 Jul 2021 11:28:22 -0600 Message-ID: Subject: Re: git: 6edf5082bab7 - stable/12 - one-true-awk: import 20210221 (1e4bc42c53a1) which fixes a number of bugs To: Kristof Provost Cc: Warner Losh , src-committers , "" , dev-commits-src-branches@freebsd.org X-Rspamd-Queue-Id: 4GcWT32WsDz4mLC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jul 2021 17:28:39 -0000 On Sat, Jul 31, 2021 at 9:37 AM Kristof Provost wrote: > On 31 Jul 2021, at 16:20, Warner Losh wrote: > > On Sat, Jul 31, 2021 at 8:07 AM Warner Losh wrote: > > > >> > >> > >> On Sat, Jul 31, 2021 at 3:11 AM Kristof Provost > >> wrote: > >> > >>> Hi Warner, > >>> > >>> On 10 Jul 2021, at 19:12, Warner Losh wrote: > >>> > >>> The branch stable/12 has been updated by imp: > >>> > >>> URL: > >>> > https://cgit.FreeBSD.org/src/commit/?id=3D6edf5082bab71cf923efff9f18e38ef= e5b83b0ec > >>> > >>> commit 6edf5082bab71cf923efff9f18e38efe5b83b0ec > >>> Author: Warner Losh > >>> AuthorDate: 2021-07-07 23:30:35 +0000 > >>> Commit: Warner Losh > >>> CommitDate: 2021-07-10 17:11:15 +0000 > >>> > >>> one-true-awk: import 20210221 (1e4bc42c53a1) which fixes a number of > >>> bugs > >>> > >>> Import the latest bsd-features branch of the one-true-awk upstream: > >>> > >>> o Move to bison for $YACC > >>> o Set close-on-exec flag for file and pipe redirects that aren't > >>> std* > >>> o lots of little fixes to modernize ocde base > >>> o free sval member before setting it > >>> o fix a bug where a{0,3} could match aaaa > >>> o pull in systime and strftime from NetBSD awk > >>> o pull in fixes from {Net,Free,Open}BSD (normalized our code with > >>> them) > >>> o add BSD extensions and, or, xor, compl, lsheift, rshift (mostly a > >>> nop) > >>> > >>> Also revert a few of the trivial FreeBSD changes that were done > >>> slightly > >>> differently in the upstreaming process. Also, our PR database may > >>> have > >>> been mined by upstream for these fixes, and Mikolaj Golub may > >>> deserve > >>> credit for some of the fixes in this update. > >>> > >>> Suggested by: Mikolaj Golub > >>> PR: 143363,143365,143368,143369,143373,143375,214782 > >>> Sponsored by: Netflix > >>> > >>> (cherry picked from commit f39dd6a9784467f0db5886012b3f4b13899be6b8) > >>> > >>> I *think* this is the relevant commit, but I=E2=80=99m not 100% sure. > >>> > >>> Anyway, I=E2=80=99ve recently started seeing issues building pfSense = for > >>> aarch64. > >>> I=E2=80=99ve finally narrowed it down, and replicated the problem on = base > >>> FreeBSD > >>> (stable/12, but I assume other branches are affected too). > >>> > >>> It fails to build proctab.c. This file is generated by maketab, a > >>> tool > >>> built as part of the build process. In my case this tool is built > >>> for > >>> aarch64, which makes executing it on amd64 less successful than > >>> we=E2=80=99d like. > >>> > >>> This only happens when building with META_MODE though. I do not > >>> understand the build system sufficiently to debug why. Hopefully > >>> you=E2=80=99ll > >>> have a better idea. > >>> > >> Generally I do, but this one is a bit weird. Also, the amount of > >> context > >> you've included omits the actual error :( Though I'm guessing it's > >> wrong > >> arch for the build tool... > >> > >> I rarely use meta mode, and understand it not at all, but awk follows > >> the > >> same patterns as /bin/sh and /bin/csh does > >> > > > > [[ stupid gmail ]] > > > > I've just pushed removal of proctab.c. That may fix this, though I'm > > not > > hopeful. > Unfortunately that didn=E2=80=99t help. > > > I've rarely used metamode, and not for quite some time, but this > > an extra file that would confuse things so that maketab might not be > > built > > during build-tools and instead is built later. Please give that a try, > > and > > I'll start a meta build, but that takes a while, not least because I > > have > > to re-leran how to do that :) > > > I=E2=80=99ve posted my build log and the proctab.c.meta and maketab.meta = files > on https://people.freebsd.org/~kp/meta/ > > I=E2=80=99m a little confused by maketab.meta, because what=E2=80=99s in = the meta > file doesn=E2=80=99t seem to match the build command seen in the metamode= .log > file. > Yea. It's getting confused and rebuilding it bogusly. For the mknodes in sh, we don't see the naked cc command, but we do for maketab. I'm testing a fix right now, though, and we'll see if that fixes things. I think I know what's going on. Warner