From nobody Wed Sep 27 23:11:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rwsmb5xMRz4v7KF; Wed, 27 Sep 2023 23:11:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rwsmb55pgz4b4p; Wed, 27 Sep 2023 23:11:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695856271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zs8YC0M2KdoBQfeF8VnuL6J7ekpSJ789UQqAO2l1jvo=; b=jHrOTlW1rr0BXYlTvhS/yfEuoexAx41THVITCc103H9UtgFuld3GX6n/TiTujEIIqxNB9n tnp7kFhY7oNsxWhiviTX28eFxqpaDSyjJF0K1ioWxbcZ/1lcfJ1iiQMqHi8Hb4plZo7h7w HtTqYsjBkgJ3SESYBTLIM8/bX9Cpo4a16MQDy66I9DrDZKUhnjueza6XhbRMoOhHmYzGCh +4eh0tL4UhbuYQ6L4+qkQddLZ53Y4bN3sqGl415og4TuUqAyLluB723y6Ejw6qWuTtjf9w 9WcnZ5jNledNzbC6ot728u4vKrN33EUfd7GBM1qJg2HogvkDX14WfQouy8kSug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695856271; a=rsa-sha256; cv=none; b=jh08sOVoay/ZlA1tBjOjy2mjFv5adaVt3hqoYrBXiU+VHmB6mvHH1wh4Es3nzbgV/b3eSk I3tI66Sh/ZhZtcKSneS0e2x+K0vaLr+94lp7MQbY4+deRarMn6aYz5slMUgRzKuVStb2Tt vWo9LD749aMxl2EoYYych0qsQWrYsi0ZaTGViHaCYnYWY4D8E1dGXSCEvU+KdxaqH0QyS8 GQrbKkJOaVSrX8vkcqEseybsgJazUSBuYK8znYXxUOits04OFcnQQ3kL8OgKIg0coMp/Jl tb32Ifpr6kSpoLpe2VU6/F+vFonAVWj011FCYaFY/nRR9uMunpK4sNohCn+rXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695856271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zs8YC0M2KdoBQfeF8VnuL6J7ekpSJ789UQqAO2l1jvo=; b=rf7Wr/hBegy9dKGPrOn/bnmFOlfeU6ntKymLXRX2YoucT2zIMn99bD4AeZ95ezB6/XvvN4 sjL9hgkUzSrSFcTHLs+7A97moZtkQNwG37vCX9pL4Z3pdSQyu974sNKgY7hBB4vu4VkK8T Mwy1W2k1gKlJHBPPNESHMChMX2Cu+Bqzgvu93hjZO4Pcs6SL+MRwaOyS+EfBB8d4rxYwKG difXwTVTAqdjYDxhjStWDoKxOCsiqL8LUSouOps7RHGnB/RVtqnDs6km4NOS/8iGw6wY6/ fhhjQHeo0kmarQeC6OAvQii5MLmAn+vfGda8bPVezZMB3t8Rz+sPNUEj7eq1zw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rwsmb3px2zxDy; Wed, 27 Sep 2023 23:11:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38RNBBgb052445; Wed, 27 Sep 2023 23:11:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38RNBBuc052442; Wed, 27 Sep 2023 23:11:11 GMT (envelope-from git) Date: Wed, 27 Sep 2023 23:11:11 GMT Message-Id: <202309272311.38RNBBuc052442@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: fc4a6768272e - main - newvers: Add comment about why we need sccs, but deprecate it List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fc4a6768272ea9e943661e0c34ff436dac872ac7 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=fc4a6768272ea9e943661e0c34ff436dac872ac7 commit fc4a6768272ea9e943661e0c34ff436dac872ac7 Author: Warner Losh AuthorDate: 2023-09-27 23:07:53 +0000 Commit: Warner Losh CommitDate: 2023-09-27 23:07:53 +0000 newvers: Add comment about why we need sccs, but deprecate it The SCCS ID is still the most reliable way to dig out the version information from the kernel w/o false positives. Add a comment to that effect. savecore(8) neglects to save the kerneldumpheader that would have the version information at a fixed location. savecore(8) needs to be augmented to have the right data in the right places, but until then the old-school SCCS id needs to remain. Once that's fixed, we plan to remove it. The reason it needs to be in a fixed or easily findable location is because if you have an arbitrary core and want to pull the source and build artificts that went along with that core, you don't yet have the symbols you need to read the version string. To solve the chicken / egg problem, one needs an independent way to know what to use so that automated analysis of cores can happen. The sccs id being in the kernel ensures that it is in the core image written. The what(1) utility makes extracting the version easy. Sponsored by: Netflix Reviewed by: cy, emaste Differential Revision: https://reviews.freebsd.org/D41984 --- sys/conf/newvers.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh index 73fd6857d307..33615a8d94f8 100644 --- a/sys/conf/newvers.sh +++ b/sys/conf/newvers.sh @@ -311,6 +311,14 @@ fi vers_content_new=$(cat << EOF $COPYRIGHT +/* + * The SCCS stuff is a marker that by convention identifies the kernel. While + * the convention originated with SCCS, the current use is more generic and is + * used by different organizations to identify the kernel, the crash dump, + * etc. The what(1) utility prints these markers. Better methods exist, so this + * method is deprecated and will be removed in a future version of FreeBSD. Orgs + * that use it are encouraged to migrate before then. + */ #define SCCSSTR "@(#)${VERINFO}" #define VERSTR "${VERSTR}" #define RELSTR "${RELEASE}"