From nobody Sat Feb 7 00:58:26 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f7CJ26Bm9z6Qs1y for ; Sat, 07 Feb 2026 00:58:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f7CJ24h54z3M7X for ; Sat, 07 Feb 2026 00:58:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770425906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y26gC4B0idGd5ZnoSZm6wYRvkiv+vUKz7eErt0K1dBE=; b=Ph3sQIexHRhEIYTqWc97f4yhE7gJvaw4Lp6Fus0m8t3/eWepFQNa9Z7ECwFe31QsAak5W4 +NFO1DY4Kh1c0SRbJqUfZZkJl0sOTYIb4kyN7p4OjC6H4JMgFFl60RLQROOHagA1Ei+2am EEhc+OTUZktMWDkPdSLq1YAYJI+gp7U1WmiAgoAUKFY4HLgcNrwCrxmaWlUU57KKeD4qYp zsrdSZW1hPvB20Sgnk9bqRg6OumbwhQK7ZUr/W3BByA++cQknF7BgYC9exdjU6yELnA5wx YT3uJu4a2q3CnbvaltcAp1cXKMsbwteuMIA5UKUtlt5rXjXURXZ+HNzeyUHqEg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770425906; a=rsa-sha256; cv=none; b=DXfNeX+YEarI6lJDYnKfVF2bqxcPafB/SdTuwrQbpT+QHBWmpC/xffDyZfpZZ2Uayv9MKj AFxL6hiXR0lOew+t1RzjfKhr29Qj7+maA6dxXtOcKJaXhqyFtWjeDK8+Db+z4I59k5bK2Y dD4ts4lQ4srL66DMrJPzBgcKpl0Hz/DDUvibnkiawCn0ZSWl4OpuVhILl4STbKumVUai+e YRXda0/QwGBkAK0x+8y4KfSjhReUy2A5HX4RJtTrqdnCNzLp4Vf7eR1HnpUWVEeyJPDxfs lf8lKhYJABQjeKg2NZCgeRvhPbkUyTBbW6sl0Q/mqBr6kwGFruFQoSROzq2yeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770425906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y26gC4B0idGd5ZnoSZm6wYRvkiv+vUKz7eErt0K1dBE=; b=Kb/+LrovEJkCqiwNT5nKj62QP0aDJQ3K5PonqXRfufkF+3tJwgxFHwueR36l1WmvspjAr0 3ouG9m5wSMi3wTTRg0BFI6bYj+rv+qOnTFEDBcAmAsYeQZH2ASh9MlxymM1QH8Qr732HNf cZXLs3lVO1YfeEeVDVpYt2MaT+upgrc1Ee5TI31TIaQddHJq2g8H24vcByRUllkKuxyk35 Qdwe9qwGR+82widL8IC96cb9VHYGF4I5zn72xCS67+dvd+iS1nqD7MpCIdHKhGFWdgLyYU e1b5DG/K7e957g7pmPRywOil38DQrABd3sONs7ou06YZYxymKc3RWaqGjv43vQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f7CJ24Gr2zfYH for ; Sat, 07 Feb 2026 00:58:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34414 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 07 Feb 2026 00:58:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 3afe9e12fb33 - main - mt76: fix a check wrongly giving us random ether addresses all the time List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3afe9e12fb331dc698ac62f3b918d82d768a2792 Auto-Submitted: auto-generated Date: Sat, 07 Feb 2026 00:58:26 +0000 Message-Id: <69868e32.34414.2ac53743@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=3afe9e12fb331dc698ac62f3b918d82d768a2792 commit 3afe9e12fb331dc698ac62f3b918d82d768a2792 Author: Bjoern A. Zeeb AuthorDate: 2026-02-05 00:20:04 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-02-07 00:57:52 +0000 mt76: fix a check wrongly giving us random ether addresses all the time Do not cover the is_valid_ether_addr() check under CONFIG_OF. Unclear if this is an initial porting or a merging error before the driver hit the FreeBSD src tree. The end result was that we always got a random link-layer address, while the individual drivers may have setup phy->macaddr and this function would only overwride if given in device tree. Only if both, driver and and the OF backup, fail then go and use the random link-layer address. While here adjust printing the random link-layer address using a FreeBSD format specifier and not the unsupported Linux one. Fixes: 6c92544d7c97 Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/contrib/dev/mediatek/mt76/eeprom.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sys/contrib/dev/mediatek/mt76/eeprom.c b/sys/contrib/dev/mediatek/mt76/eeprom.c index 1d5b95226a16..99e1bca3c19f 100644 --- a/sys/contrib/dev/mediatek/mt76/eeprom.c +++ b/sys/contrib/dev/mediatek/mt76/eeprom.c @@ -186,16 +186,19 @@ mt76_eeprom_override(struct mt76_phy *phy) err = of_get_mac_address(np, phy->macaddr); if (err == -EPROBE_DEFER) return err; +#endif if (!is_valid_ether_addr(phy->macaddr)) { -#endif eth_random_addr(phy->macaddr); dev_info(dev->dev, +#if defined(__linux__) "Invalid MAC address, using random address %pM\n", phy->macaddr); -#if defined(CONFIG_OF) - } +#elif defined(__FreeBSD__) + "Invalid MAC address, using random address %6D\n", + phy->macaddr, ":"); #endif + } return 0; }