From owner-svn-src-all@FreeBSD.ORG  Mon May 25 11:45:14 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 38FB584D;
 Mon, 25 May 2015 11:45:14 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 14599DE;
 Mon, 25 May 2015 11:45:14 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net
 [173.54.116.245])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9B9BCB939;
 Mon, 25 May 2015 07:45:12 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Alexander V. Chernikov" <melifaro@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r283364 - head/sys/sys
Date: Mon, 25 May 2015 07:27 -0400
Message-ID: <1698551.fhQlKrx2sg@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201505241124.t4OBOFe6030452@svn.freebsd.org>
References: <201505241124.t4OBOFe6030452@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 25 May 2015 07:45:12 -0400 (EDT)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2015 11:45:14 -0000

On Sunday, May 24, 2015 11:24:15 AM Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sun May 24 11:24:14 2015
> New Revision: 283364
> URL: https://svnweb.freebsd.org/changeset/base/283364
>=20
> Log:
>   Fix SIOCGI2C structure requirement.
>  =20
>   In reality, SIOCGI2C ioctl requires struct ifreq as many other
>   ioctls. Doing copyin() on (significantly) larger struct ifstat some=
times
>   triggered EFAULT.
>  =20
>   Reported by:=09Olivier Cochard-Labb=E9 <olivier at cochard.me>
>   MFC after:=091 week

Note that this breaks the ABI.  You may wish to add a SIOCGI2C_OLD that=

still uses the larger struct so that old programs continue to work.  OT=
OH,
they were only working by accident before.  If we expect that no code
outside of ifconfig is using this yet, then it is probably ok to let th=
is
slide.

--=20
John Baldwin