Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Mar 2014 08:24:36 +0530
From:      ashish@FreeBSD.org (Ashish SHUKLA)
To:        David Thiel <lx@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r348595 - in head/net-im/prosody: . files
Message-ID:  <86fvmezymr.fsf@chateau.d.if>
In-Reply-To: <201403182019.s2IKJYTf028699@svn.freebsd.org> (David Thiel's message of "Tue, 18 Mar 2014 20:19:34 %2B0000 (UTC)")
References:  <201403182019.s2IKJYTf028699@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi David,

I updated my ports tree few minutes ago, and noticed couple of issues with
this commit.

On Tue, 18 Mar 2014 20:19:34 +0000 (UTC), David Thiel <lx@FreeBSD.org> said:
> Author: lx
> Date: Tue Mar 18 20:19:34 2014
> New Revision: 348595
> URL: http://svnweb.freebsd.org/changeset/ports/348595
> QAT: https://qat.redports.org/buildarchive/r348595/

> Log:
>   Stageify and modernize.
=20=20
>   PR:		ports/187703
>   Submitted by:	Scot Hetzel
>   Reviewed by:	me

> Deleted:
>   head/net-im/prosody/files/pkg-install.in
> Modified:
>   head/net-im/prosody/Makefile
>   head/net-im/prosody/files/patch-Makefile
>   head/net-im/prosody/files/pkg-deinstall.in
>   head/net-im/prosody/pkg-plist

> Modified: head/net-im/prosody/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/net-im/prosody/Makefile	Tue Mar 18 20:14:23 2014	(r348594)
> +++ head/net-im/prosody/Makefile	Tue Mar 18 20:19:34 2014	(r348595)
> @@ -17,29 +17,28 @@ RUN_DEPENDS=3D	${LUA_MODLIBDIR}/socket/cor
>  		${LUA_MODLIBDIR}/lxp.so:${PORTSDIR}/textproc/luaexpat \
>  		${LUA_MODLIBDIR}/lfs.so:${PORTSDIR}/devel/luafilesystem \
=20
> -LIB_DEPENDS=3D	idn:${PORTSDIR}/dns/libidn
> +LIB_DEPENDS=3D	libidn:${PORTSDIR}/dns/libidn

I don't think change was needed, as with this, it tries to install libidn e=
ven
when it is already installed.

> +
> +USERS=3D		prosody
> +GROUPS=3D		${USERS}
=20
>  USE_RC_SUBR=3D	prosody
> -MAN1=3D	prosodyctl.1
>  MANCOMPRESSED=3D	no
=20
> +USES=3D	gmake shebangfix
>  USE_LUA=3D	5.1
>  WANT_LUA_VER=3D	5.1
> -USE_GMAKE=3D	yes
> +SHEBANG_LANG=3D	lua
> +SHEBANG_FILES=3D	prosody prosodyctl
> +lua_OLD_CMD=3D	${SETENV} lua
> +lua_CMD=3D	${LUA_CMD}
=20
>  HAS_CONFIGURE=3D	yes
>  CONFIGURE_ARGS+=3D	--ostype=3Dfreebsd --c-compiler=3D"${CC}" --linker=3D=
"${LD}"
>  CONFIGURE_ENV+=3D	LOCALBASE=3D"${LOCALBASE}" PREFIX=3D"${PREFIX}" LUA_SU=
FFIX=3D"-${LUA_VER}" LUA_LIBDIR=3D"${LUA_LIBDIR}" LUA_INCDIR=3D"${LUA_INCDI=
R}"
=20
> -SUB_FILES=3D	pkg-install pkg-deinstall
> -
> -NO_STAGE=3D	yes
> -pre-install:
> -	${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
> -	${REINPLACE_CMD} -e 's|/usr/bin/env lua|${LUA_CMD}|' ${WRKSRC}/prosody.=
install ${WRKSRC}/prosodyctl.install
> -
> -post-install:
> -	${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
> -	@${CAT} ${PKGMESSAGE}
> +SUB_FILES=3D	deinstall

s/deinstall/pkg-deinstall/

HTH
=2D-=20
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
Sent from my Emacs

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBCgAGBQJTKQbyAAoJEMdGz6nnT6SwiM4QAI4HYHFDIFcCjvRh77PPcPUL
tfWRwlYIBTs/clbbUs2CYp9nuX+JK1719MI6AY6nTQPiRMtdIW0n+OZflGm0Bgv7
zuu024cYf63dZ/rr1zsJJ0e+yf0l3c9oMpnZoy9UpKbP4NCtrju5EmCqG/4zMpnO
DFFuRJozVc9xgQQJNASCwcath+2SYgNWCkqo5mpO2fdR4l9mD62tVwOZvmsYs9wn
SxfoDD3XfPNPWCmJJkIVBMXxZyokS1VlSFxNL2mbM8CNNyvU0AIJPJm1/Szkt1Ge
iN4Q+enyEJLRPLHRyujag4d92lgjMgw9HIIbq7KojNFfncEvz7El3sVVpTgjWACI
eoGBBhKggmwK7TWJpdLuZfUTLWsZZDV9LjTj9VTwQv6SxpaxWpxYgCkseD3+mMOr
XDZwMChveZmx7fwUDwgZN82N32tgOURTM0ASbQLiHBSgDSTWh5lTQPyvJcNRjtm3
rCcJiGmqXQErFgCy+4MnxNXhaYHw+v56CgNFzu+H6AUpdFbdASZZEvuX4DiNbHZY
SFR/HwGHDCbq1exyzlcy70TIQ86KZbcPWMPwIwDPdRmfCoN/THz4h2Oh+/MakvWb
XygghmtxLRYNw42ytktMNCyDPA67UAoiIkWyh8/mloBQo2HCZDxq9gqB/PGRnUTv
IryykTDunwhvK5twt+xo
=JMCS
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86fvmezymr.fsf>