From owner-freebsd-ports-bugs@FreeBSD.ORG Thu May 22 13:00:16 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 738BC37B401 for ; Thu, 22 May 2003 13:00:16 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 465C643FA3 for ; Thu, 22 May 2003 13:00:15 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h4MK0FUp099390 for ; Thu, 22 May 2003 13:00:15 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h4MK0FnH099389; Thu, 22 May 2003 13:00:15 -0700 (PDT) Resent-Date: Thu, 22 May 2003 13:00:15 -0700 (PDT) Resent-Message-Id: <200305222000.h4MK0FnH099389@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, linimon@lonesome.com Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15D4C37B401 for ; Thu, 22 May 2003 12:49:58 -0700 (PDT) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA5E943F85 for ; Thu, 22 May 2003 12:49:56 -0700 (PDT) (envelope-from linimon@lonesome.com) Received: from lonesome.lonesome.com (cs242746-11.austin.rr.com [24.27.46.11]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mail.soaustin.net (Postfix) with ESMTP id 5895814354 for ; Thu, 22 May 2003 14:49:53 -0500 (CDT) Received: from lonesome.lonesome.com (localhost.lonesome.com [127.0.0.1]) by lonesome.lonesome.com (8.12.9/8.12.3) with ESMTP id h4MJr5gZ035363 for ; Thu, 22 May 2003 14:53:06 -0500 (CDT) (envelope-from linimon@lonesome.lonesome.com) Received: (from linimon@localhost) by lonesome.lonesome.com (8.12.9/8.12.6/Submit) id h4MJr4Fa035362; Thu, 22 May 2003 14:53:04 -0500 (CDT) (envelope-from linimon) Message-Id: <200305221953.h4MJr4Fa035362@lonesome.lonesome.com> Date: Thu, 22 May 2003 14:53:04 -0500 (CDT) From: Mark Linimon To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113.1 Subject: ports/52590: [non-maintainer update] update logic for "BROKEN" variable in audio/aureal-kmod X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: linimon@lonesome.com List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2003 20:00:16 -0000 >Number: 52590 >Category: ports >Synopsis: [non-maintainer update] update logic for "BROKEN" variable in audio/aureal-kmod >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu May 22 13:00:14 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Mark Linimon >Release: FreeBSD 4.7 >Organization: lonesome.com >Environment: System: FreeBSD lonesome.lonesome.com 4.7-STABLE FreeBSD 4.7-STABLE #0: Fri Nov 8 23:46:29 CST 2002 root@lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA i386 >Description: The current logic to calculate BROKEN in this port does not allow for one OS release to ask the port if it is broken on another OS release. This is due to an assumption that the OSVERSION passed to the Makefile exactly corresponds to the source version installed under /usr/src/sys (if any.) That is the default. However, when doing a cross-query, this is not the case. While this is a problem that is probably only of interest to myself, Bill Fenner, and Dan Langille, the logic could use tightening anyway. >How-To-Repeat: (on a 4.7 system, e.g.): cd /usr/ports/audio/aureal-kmod; make OSVERSION=50000 -V BROKEN will result in failure. >Fix: The following patch emulates the current behavior of the port Makefile on both the 4.7 and 5.0 releases without OSVERSION being set. In addition, it works for OSVERSION being set. --- aureal-kmod/Makefile.dist Fri Feb 21 07:14:26 2003 +++ aureal-kmod/Makefile Thu May 22 14:32:41 2003 @@ -36,8 +36,7 @@ VERSION_SOUND_C= .endif -VERSION_SOUND_C_CURRENT:= ${VERSION_SOUND_C:S/1.//} -VERSION_SOUND_C_STABLE:= ${VERSION_SOUND_C:S/1.17.2.//} +VERSION_SOUND_C_MINOR:= ${VERSION_SOUND_C:S/^1.//:S/^17.2.//} .if ${OSVERSION} < 410000 BROKEN= "FreeBSD 3.*, 4.0 are not supported" @@ -51,7 +50,7 @@ # FreeBSD 4.2, 4.3 PORTVERSION= 1.3 -.if ${VERSION_SOUND_C_STABLE} < 4 +.if ${VERSION_SOUND_C_MINOR} < 4 # FreeBSD 4.2 before kobj MFC PORTREVISION= 1 @@ -69,7 +68,7 @@ .elif ${OSVERSION} < 500000 # FreeBSD 4.5+ -.if ${VERSION_SOUND_C_STABLE} < 12 +.if ${VERSION_SOUND_C_MINOR} < 12 BROKEN= "Base system is outdated. This port needs -STABLE after 2002-04-22." .endif PORTVERSION= 1.3 @@ -79,7 +78,7 @@ .if ${OSVERSION} > 500000 # FreeBSD 5-CURRENT -.if ${VERSION_SOUND_C_CURRENT} < 70 +.if ${VERSION_SOUND_C_MINOR} < 70 BROKEN= "Base system is outdated. This port needs -CURRENT after 2002-04-04." .endif .endif >Release-Note: >Audit-Trail: >Unformatted: