From owner-freebsd-x11@freebsd.org Sun Feb 23 22:36:14 2020 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E0C424B18A for ; Sun, 23 Feb 2020 22:36:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48Qg5p1kzsz4Hh4 for ; Sun, 23 Feb 2020 22:36:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3B6AB24B188; Sun, 23 Feb 2020 22:36:14 +0000 (UTC) Delivered-To: x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3B15324B186 for ; Sun, 23 Feb 2020 22:36:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Qg5n6kCcz4Hgk for ; Sun, 23 Feb 2020 22:36:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8E0DE1BA7A for ; Sun, 23 Feb 2020 22:36:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01NMaDtN006881 for ; Sun, 23 Feb 2020 22:36:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01NMaDJX006880 for x11@FreeBSD.org; Sun, 23 Feb 2020 22:36:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 244353] x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and minor cleanup) Date: Sun, 23 Feb 2020 22:36:13 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 22:36:14 -0000 Bugzilla Automation has asked freebsd-x11 mailing li= st for maintainer-feedback: Bug 244353: x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and minor cleanup) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244353 --- Description --- Besides pulling in the patch from github, this also does some minor cleanup to pacify portlint. See https://github.com/rayddteam/xf86-video-scfb/pull/4 When loading scfb on xorg 1.20.7 it fails with an undefined symbol error: scfb trace: probe start scfb trace: probe done scfb: PreInit 0 scfb: PreInit done scfb: ScfbScreenInit 0 bitsPerPixel=3D32, depth=3D24, defaultVisual=3DTrueColor mask: ff0000,ff00,ff, offset: 16,8,0 mmap returns: addr 0x805a10000 len 0x640000, fd 12, off 0 scfb: ScfbSave 0 scfb: ScfbSave done scfb: ScfbScreenInit done ld-elf.so.1: /usr/local/lib/xorg/modules/drivers/scfb_drv.so: Undefined symbol "shadowUpdatePackedWeak" Disabling ShadowFB makes the driver load, but breaks output. With this fix, the driver loads and was reported to work properly (at least for "normal" daily use). The fix was inspired by a similar change in fbdev: freedesktop/xf86-video-fbdev@2673e72 Fix tested on two machines, port build qa with poudriere testport on amd64 and i386 still running.