From owner-cvs-all@FreeBSD.ORG Thu Mar 27 10:08:24 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6ABD437B40A for ; Thu, 27 Mar 2003 10:08:24 -0800 (PST) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DAA643FEA for ; Thu, 27 Mar 2003 10:08:20 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 12076 invoked from network); 27 Mar 2003 18:08:25 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 27 Mar 2003 18:08:25 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h2RI8IOv002403; Thu, 27 Mar 2003 13:08:18 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Thu, 27 Mar 2003 13:08:18 -0500 (EST) From: John Baldwin To: (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) X-Spam-Status: No, hits=-19.5 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REPLY_WITH_QUOTES version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/linux linux_sysvec.c src/sys/compat/linux linux_mib.c linux_mib.h src/sys/i386/linux linux_sysvec.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2003 18:08:27 -0000 On 27-Mar-2003 Dag-Erling Smørgrav wrote: > John Baldwin writes: >> Log: >> Add a cleanup function to destroy the osname_lock and call it on module >> unload. > > This would work a lot better if linux_sysvec.c actually included > linux_mib.h so it would have a prototype for linux_mib_destroy(). Weird, someone had tested this patch and it stopped their panic and there was no report of any compile problems. :( As a side note, there is a good deal of duplicated code in the module event functions in the linux_sysvec.c files. Ugh. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/