From owner-freebsd-apache@FreeBSD.ORG Mon Feb 24 14:41:17 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B46F1121; Mon, 24 Feb 2014 14:41:17 +0000 (UTC) Received: from mail-yk0-x230.google.com (mail-yk0-x230.google.com [IPv6:2607:f8b0:4002:c07::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3DD9F1DC4; Mon, 24 Feb 2014 14:41:17 +0000 (UTC) Received: by mail-yk0-f176.google.com with SMTP id 19so14711873ykq.7 for ; Mon, 24 Feb 2014 06:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=/2otc+gWos7NpEV/8/QJ2iCbElRrI34s5KSfmNs1mXc=; b=KBhbO/oZM3enoWsVVCovkO+4UOLuXGF0zhHSRORCMgyOy6iniVA39U6TB9BF+8HhCN Hrkj3t91UoYKctfut9QKa+AX94InDE6esfFHjrBObfiLvPm94KK18pkmYKg+nSfu7fYe ZRcQiDCpOz4EXXQR/TD8mOpLiHrX4CNDLAw2BrDVDS9JAFDFARLDl/5OlXOVJrJmCU7l 0SJrxyfnixlAQzuv9GMIJJXjNdkt75aDYKfryYSTDlBmEyZq2odhTOXtSafo4syKcwlj FHTeN7zU7mAqRRlQNgdgnAJUF/AVBfMH2POABBG/R0pG4qxp1G/g04vPcQI2pxlnHsjm FiSA== MIME-Version: 1.0 X-Received: by 10.236.81.237 with SMTP id m73mr31151741yhe.29.1393252876350; Mon, 24 Feb 2014 06:41:16 -0800 (PST) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.80.11 with HTTP; Mon, 24 Feb 2014 06:41:16 -0800 (PST) In-Reply-To: References: <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> Date: Mon, 24 Feb 2014 15:41:16 +0100 X-Google-Sender-Auth: Camd1bYh2ruA5uS-joG3KPDWe6U Message-ID: Subject: Re: Patch for devel/apr1 From: Antoine Brodin To: Eygene Ryabinkin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Mathieu Arnold , apache@freebsd.org, FreeBSD Ports Management Team X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2014 14:41:17 -0000 On Mon, Feb 24, 2014 at 3:30 PM, Eygene Ryabinkin wrote: > Mathieu, good day. > > Mon, Feb 24, 2014 at 02:40:34PM +0100, Mathieu Arnold wrote: >> +--On 24 f=E9vrier 2014 04:31:40 +0400 Eygene Ryabinkin >> wrote: >> | Sat, Feb 22, 2014 at 12:04:51PM +0400, Eygene Ryabinkin wrote: >> |> Thu, Feb 20, 2014 at 11:16:40PM +0400, Eygene Ryabinkin wrote: >> |> > Attached is the patch that fixes handling of WITH_/WITHOUT_ knobs >> |> > (and may be something else). How to reproduce: set WITH_LDAP via >> |> > make's command line and build apr1. You will end up with APR that >> |> > doesn't support LDAP. Tested on port's HEAD@r343654. >> |> >> |> Gentlemen? Is anyone around to look at this? >> | >> | Involving portmgr. Gentlemen, devel/apr1 doesn't have OPTIONS_DEFINE = set, >> | so this breaks at least handling of WITH/WITHOUT options. Can I have >> | approval for the patch? >> >> Hum, no, I don't see why it would be needed. What does it fix ? > > Building with 'make WITH_LDAP=3Dyes', for example. It won't produce > your LDAP-powered APR if you hadn't used 'make options' and selected > LDAP there before. > > Do you familiar with > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.= html > section 5.12.2.2? Or, alternatively, with Mk/bsd.options.mk lines 178, > {{{ > ALL_OPTIONS:=3D ${OPTIONS_DEFINE:O:u} > }}} > and block starting at line 260 > {{{ > .for opt in ${ALL_OPTIONS} > .if defined(WITH_${opt}) > PORT_OPTIONS+=3D ${opt} > .endif > .if defined(WITHOUT_${opt}) > PORT_OPTIONS:=3D ${PORT_OPTIONS:N${opt}} > .endif > .endfor > }}} Hi, WITH_LDAP syntax is deprecated and doesn't work for options in a group. You can use make WITH=3DLDAP Cheers, Antoine