From owner-svn-src-all@freebsd.org Wed Mar 4 22:22:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 633AA253C1C; Wed, 4 Mar 2020 22:22:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48XpJm0kQkz3Hgn; Wed, 4 Mar 2020 22:21:59 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf44.google.com with SMTP id r15so1558078qve.3; Wed, 04 Mar 2020 14:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LccLuqP9Qtee+rC3EDJMYP7apsF9sTWKY5BOEUG1IvQ=; b=FB9lWCXqpf7w4+KozCUZ5unNl/nLiSQ0a3sfFARAgjU3qQdSUEfuvIwodoYgN2Fr+d 8jiEutHK/m+0lzmIXq1FN7EHpknpIsNVRgqrvtzCyoA6v6MTHjhXwXMl4coecQE+uOi1 VyVc1VELrSkpcm7wrgdaWJtTugMss2ojOdJXgNNvy7wdNynVLSG8ESvJ2zNSIty8RHhj 0XrXpWG7ZCHn+AtC5DnHGe08cC88A8kTG1nRewKXC3KmCE9v7ey0xmXawK3fyYHtq/MW RqDsQv7V9D0uMI+/GboTEiwi/7x/3zfoC7bY5pBnbiDhbI41NrdQXt8EH87wEqsPteWi XzIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=LccLuqP9Qtee+rC3EDJMYP7apsF9sTWKY5BOEUG1IvQ=; b=Y94FBJNJ/8MmlvS4qD7DhyFG9DocpuZAyFutneFkAtximFfcb+f0D6Kk7X+OY4L5BT 8XnxiJ1IKLBjPfDYKwf+/pRqtYf2evaFBWNAsyAFzvsFwnXKHJV9W//F0XLwBnxzEU2f p3qHkRni/drQFlnbOJSOqSYBXZY5Nd5q4Te5plB7ePPDbirwlRz2vuqMK8lkG7vNfjAl nBZC5NaKFgMDZLSW2BkR2Y0vq9SxPMQGxbERAqiKgPP7Xx6DemPFfFvatwo8nLoufNYi uRMNloXnFoygsSlLWb1Ve9PQW092LHTlK3hJyxraJRrPchiW/J6VTTEPg7eRcF1styTV y7ug== X-Gm-Message-State: ANhLgQ0YSvPe8TtFyY7Eq0ffXBobfQGUzCB5W6/ify6xnvmZLUg8fiOj u6bPwP/2Jycz5vEOkjXdLwTWOxef X-Google-Smtp-Source: ADFU+vsMGTi8kCukC9TmkaKkxcnS3mMvBJpOBVQsjVJkPzHjruUJ+Nw7RLUknHuwmEsJrExvj+hR2A== X-Received: by 2002:a0c:fc46:: with SMTP id w6mr3825507qvp.46.1583360518737; Wed, 04 Mar 2020 14:21:58 -0800 (PST) Received: from raichu (toroon0560w-lp130-11-70-50-21-248.dsl.bell.ca. [70.50.21.248]) by smtp.gmail.com with ESMTPSA id h9sm14813575qtq.61.2020.03.04.14.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 14:21:57 -0800 (PST) Sender: Mark Johnston Date: Wed, 4 Mar 2020 17:21:53 -0500 From: Mark Johnston To: Eric Joyner Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r358432 - in head/sys: kern sys vm Message-ID: <20200304222153.GA58468@raichu> References: <202002281605.01SG5Iox077824@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48XpJm0kQkz3Hgn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=FB9lWCXq; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f44 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.28 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.f.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.59)[ip: (0.60), ipnet: 2607:f8b0::/32(-1.86), asn: 15169(-1.66), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 22:22:01 -0000 On Wed, Mar 04, 2020 at 01:15:59PM -0800, Eric Joyner wrote: > Hi Mark, > > Is the addition of #include in sys/sys/refcount.h > actually necessary? I don't see anything in there used in refcount.h, and > the kernel appears to compile without it, at least on amd64. No, it is left over from an earlier iteration of the patch. I will remove it. Thanks. > On Fri, Feb 28, 2020 at 8:05 AM Mark Johnston wrote: > > > Author: markj > > Date: Fri Feb 28 16:05:18 2020 > > New Revision: 358432 > > URL: https://svnweb.freebsd.org/changeset/base/358432 > > > > Log: > > Add a blocking counter KPI. > > > > refcount(9) was recently extended to support waiting on a refcount to > > drop to zero, as this was needed for a lockless VM object > > paging-in-progress counter. However, this adds overhead to all uses of > > refcount(9) and doesn't really match traditional refcounting semantics: > > once a counter has dropped to zero, the protected object may be freed at > > any point and it is not safe to dereference the counter. > > > > This change removes that extension and instead adds a new set of KPIs, > > blockcount_*, for use by VM object PIP and busy.