From owner-svn-src-head@FreeBSD.ORG Mon Jul 26 09:51:00 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 631711065679; Mon, 26 Jul 2010 09:51:00 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 222338FC17; Mon, 26 Jul 2010 09:50:58 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 626CF1FFC33; Mon, 26 Jul 2010 09:50:56 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 3AA31844EC; Mon, 26 Jul 2010 11:50:56 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Gabor Kovesdan References: <201007251857.o6PIvmoS031484@svn.freebsd.org> <4C4CA13C.1090502@FreeBSD.org> Date: Mon, 26 Jul 2010 11:50:55 +0200 In-Reply-To: <4C4CA13C.1090502@FreeBSD.org> (Gabor Kovesdan's message of "Sun, 25 Jul 2010 22:40:28 +0200") Message-ID: <86ocduy3k0.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, delphij@freebsd.org, svn-src-all@freebsd.org, Doug Barton , src-committers@freebsd.org Subject: Re: svn commit: r210479 - head/usr.bin/grep X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2010 09:51:00 -0000 Gabor Kovesdan writes: > I did run regression testing, the test suite that GNU grep has. Does that test suite include a test for the bug you fixed? If not, running it before committing this particular patch was close to useless. By definition, a regression test is designed to trigger a specific bug so the developer(s) can make sure it is not reintroduced at some later point once it's been fixed. Standard procedure is for the developer to write a regression test *before* fixing the bug, and verifying that the test fails when run against the unpatched code and succeeds when run against the patched code. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no