From owner-freebsd-python@FreeBSD.ORG Tue Mar 26 05:01:10 2013 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BDEEE24B for ; Tue, 26 Mar 2013 05:01:10 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward4h.mail.yandex.net (forward4h.mail.yandex.net [IPv6:2a02:6b8:0:f05::4]) by mx1.freebsd.org (Postfix) with ESMTP id 75A2C9A4 for ; Tue, 26 Mar 2013 05:01:10 +0000 (UTC) Received: from smtp3h.mail.yandex.net (smtp3h.mail.yandex.net [84.201.186.20]) by forward4h.mail.yandex.net (Yandex) with ESMTP id E09DC1B2185B; Tue, 26 Mar 2013 09:01:01 +0400 (MSK) Received: from smtp3h.mail.yandex.net (localhost [127.0.0.1]) by smtp3h.mail.yandex.net (Yandex) with ESMTP id 9DED41B4090A; Tue, 26 Mar 2013 09:01:01 +0400 (MSK) Received: from unknown (unknown [178.76.224.133]) by smtp3h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 11kC7fUB-11kaoU9T; Tue, 26 Mar 2013 09:01:01 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1364274061; bh=+5TpBww7bu4VuQo/33q8YRWBztJ2kxnHtzPqLPi1aAY=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Ztbmx2RyNurjBLegoNH2K3Vk8CBWu0Zg/8dNlS+pmoDCi9n38v08HjRKf0iIdLBRq ABZtEVQv+yqF5ASaZRHV91LuIS+dHQEYPTHEvX6ayF2EsmSX2mtyZbDUaM7oCkT5vf eZ6J/8li0iNOAUjanJvhEWr7+oM2v8TQ3YXYO5cM= Message-ID: <51512B67.2040606@yandex.ru> Date: Tue, 26 Mar 2013 09:00:23 +0400 From: Ruslan Makhmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: freebsd-python@freebsd.org Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports References: <201303251630.r2PGU0Hf070863@freefall.freebsd.org> In-Reply-To: <201303251630.r2PGU0Hf070863@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: John Marino X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2013 05:01:10 -0000 Hi John, John Marino wrote on 25.03.2013 20:30: > The following reply was made to PR ports/177350; it has been noted by GNATS. > > From: John Marino > To: bug-followup@FreeBSD.org > Cc: > Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly > Ports > Date: Mon, 25 Mar 2013 17:26:17 +0100 > > From that error log, I'd say there was a mistake applying the patch. > There is no "ANY" definition in the compile line which the extra cxx > flags are supposed to add. > > Yes, this patch is to be applied after the existing patch is applied. > From that, you can of course regenerate a new single patch for configure. > > I think there is a misunderstanding about the nature of this PR. py-qt > builds on DragonFly Ports because I patched it. It came up on the mail > list that somebody wanted it fixed on FreeBSD. I had the solution and I > spent a couple of minutes writing a PR to let FreeBSD Ports developers > know that. > > I never meant that these patches were a drop-in fix. I didn't have the > time to generate a patch and test in on FreeBSD. I was leaving that up > to the port maintainer. > > In any case, I'd double check the work because applying this patch on > top of the existing patches *does* fix it on DragonFly and NetBSD. The > error in the log looks like the error I saw before any patch was > applied, so that's why I think suspect the patch in this PR wasn't > accurately applied. Thank you for your efforts. This is what I'm trying to compile: http://people.freebsd.org/~rm/py-qt.tgz Would you please confirm, I merged it right? PS. Unfortunately, this port is unmaintained, so in that case it's up to submitter to provide correct patch. But I had tried to and I fail :). So please help. -- Regards, Ruslan Tinderboxing kills... the drives.