From owner-freebsd-current@FreeBSD.ORG Sat Jul 9 13:34:46 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9FFF16A42C for ; Sat, 9 Jul 2005 13:34:46 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mail27.sea5.speakeasy.net (mail27.sea5.speakeasy.net [69.17.117.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3694B43D45 for ; Sat, 9 Jul 2005 13:34:46 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4141 invoked from network); 9 Jul 2005 13:34:46 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender ) by mail27.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 9 Jul 2005 13:34:45 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j69DYVq0031360; Sat, 9 Jul 2005 09:34:40 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-current@FreeBSD.org Date: Sat, 9 Jul 2005 09:32:11 -0400 User-Agent: KMail/1.8 References: <1919.1120596290@phk.freebsd.dk> In-Reply-To: <1919.1120596290@phk.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200507090932.12973.jhb@FreeBSD.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx Cc: Poul-Henning Kamp , current@FreeBSD.org Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2005 13:34:46 -0000 On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote: > This is an attempt to fix an boot0cfg/fdisk issue which I have > overlooked. > > The patch adds a g_ctl method to geom_mbr and makes boot0cfg and > fdisk use it to modify the MBR if possible. > > Please test and report ASAP in order to get this solution into > RELENG_6 Only thing I noted is that it seems that you changed boot0 to always only write 512 bytes which means it will break trying to use boot0cfg to install boot0ext (which is 2 sectors). Perhaps you should check the filesize of the boot you are writing and if it's > 512, write the other data with a write(2) after the g_ctl()? Perhaps I don't see quite understand what your g_ctl() is doing though. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org