From owner-dev-commits-src-main@freebsd.org Fri Mar 5 20:46:51 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 639115674A2; Fri, 5 Mar 2021 20:46:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dsft26Ml9z3jkS; Fri, 5 Mar 2021 20:46:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id IHLTlwjmyHmS3IHLUlRp3I; Fri, 05 Mar 2021 13:46:49 -0700 X-Authority-Analysis: v=2.4 cv=MaypB7zf c=1 sm=1 tr=0 ts=604298b9 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dESyimp9J3IA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=53RDwNlWNXt5OqmaG6AA:9 a=CjuIK1q_8ugA:10 a=6naEmYxragMA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 a=BPzZvq435JnGatEyYwdK:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 1CF0E1E4; Fri, 5 Mar 2021 12:46:47 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 125KkkJ2004952; Fri, 5 Mar 2021 12:46:46 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202103052046.125KkkJ2004952@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans cc: John Baldwin , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. In-reply-to: References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> Comments: In-reply-to Kyle Evans message dated "Fri, 05 Mar 2021 14:05:06 -0600." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 05 Mar 2021 12:46:46 -0800 X-CMAE-Envelope: MS4xfFlX2fzk978WU3Zvu2T15k3NY9+Me963oqcf5A46Ua0AURMvqwWqSrJdtPWY2T7XnrEE8gKGoEOOiAKZcotjOcuuLoZZ6o+CJaMXT87+DRlt/bN8E+E9 fRn6WR7CSeIEZ9fQ69SWRYvUh8pk6j6dGbcBtZLX/WjUMzNdXP8Q+drib9Z7IhkSWKHohtezkTX+jkno3fPlvXmie4wItONCRf6AIlK7wFM1cZIqyH09RoC7 J5AqSTP1Tlf1FHWA58HqP9TjlP7TUZEFKajE/VKxQMf3Evj+GlsUaTfvJ4kchsAsUCH2LE71qPx0PDF6spR4sPaB28a95RiHr1Gj2syeZFGrGhxcW91nbXzV UfzSkZbi X-Rspamd-Queue-Id: 4Dsft26Ml9z3jkS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 20:46:51 -0000 In message , Kyle Evans writes: > On Fri, Mar 5, 2021 at 11:55 AM John Baldwin wrote: > > > > The branch main has been updated by jhb: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=bb6e84c988d3f54eff602ed544ceaa > 9b9fe3e9ff > > > > commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff > > Author: John Baldwin > > AuthorDate: 2021-03-05 17:47:58 +0000 > > Commit: John Baldwin > > CommitDate: 2021-03-05 17:55:11 +0000 > > > > poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c > . > > > > There currently isn't a need to provide a public interface to a > > software Poly1305 implementation beyond what is already available via > > libsodium's APIs and these symbols conflict with symbols shared within > > the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c. > > > > Reported by: se, kp > > Fixes: 78991a93eb9d > > Sponsored by: Netflix > > --- > > sys/opencrypto/xform_poly1305.c | 43 ++++++++++++------------------------- > ---- > > sys/opencrypto/xform_poly1305.h | 16 --------------- > > 2 files changed, 12 insertions(+), 47 deletions(-) > > xform_poly1305.h also needs to stop being grouped in > ^/include/Makefile (reported by jenkins via np) > This resolves the build failure. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.