From owner-p4-projects@FreeBSD.ORG Fri Jul 13 14:32:00 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3B1B716A408; Fri, 13 Jul 2007 14:32:00 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D61D16A401; Fri, 13 Jul 2007 14:31:59 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 2CE1113C441; Fri, 13 Jul 2007 14:31:59 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l6DEVpKr039076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 13 Jul 2007 07:31:51 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <46978D62.8000100@errno.com> Date: Fri, 13 Jul 2007 07:34:10 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.0 (X11/20070530) MIME-Version: 1.0 To: syrinx@freebsd.org References: <200707121428.l6CESBSj045007@repoman.freebsd.org> <46965433.6050207@FreeBSD.org> <200707121831.22913.hselasky@c2i.net> <20070713034425.GH2200@deviant.kiev.zoral.com.ua> <61b573980707122359y43bb9ec4gf76892e619cc8599@mail.gmail.com> In-Reply-To: <61b573980707122359y43bb9ec4gf76892e619cc8599@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kostik Belousov , "Constantine A. Murenin" , Perforce Change Reviews , Alexey Tarasov , Hans Petter Selasky Subject: Re: PERFORCE change 123376 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2007 14:32:00 -0000 [picking a random reply] Shteryana Shopova wrote: > style(9) says: > Many of the style rules are implicit in the examples. ;) > > IMO it is a good idea to try to keep to the rules while coding. Also > all code lines should (must ;)) contain 80 characters max. Folks, before things get too out of hand, please remember there are only 2 ironclad rules about style: 1. style(9) is a guideline and not a contract 2. existing style trumps any rules in style(9) (i.e. when modifying existing code) The point being that one shouldn't get too hungup about the exact form of this person's code. The convention+practice codified in style(9) represents the agreed upon common style to use but failing to follow some rules doesn't justify getting bent out of shape. Given them advise, sure. Point out the man page, absolutely. If you program long enough you will find your personal coding style varies widely (often to suit the project environment). Sam