From nobody Wed Aug 6 20:43:41 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4by2M16Cnlz64Bvx; Wed, 06 Aug 2025 20:43:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4by2M153ZJz48vs; Wed, 06 Aug 2025 20:43:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754513021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u+orTnNFFPf2x4JqpSoMjGvtPDbMPIatMYHdmq3y6Gs=; b=K5LwaAnA/WMegZJYbrcUs+X2rioitTwXarUDbjRn9D8haraNXc+Az+2HuP6wat1cN+a2Mu PM+npGZpXDXo6F8X9/gh9jjs93FMXdusAgdTBJSR0+ICnzQtlq8Ym9EmI+F7dP+Vl5EcU3 Lp85gP0IPiVYTfHys9RO1ATrlm3/iWbBFC3v9BvZZa7faQvkSBO0E93kuF7dUGMYxDhtBo n2lAKKt5pLFRLRvlhyCnrD9092bL1AdMlwHJM6M9dbMxI72Fx6oMPyHPNgFwdW4LziEyRM /cHWRbVUhLMPsnaampk8cC8EvZRKTDPbSnueHeBMPjDzfKCi8m3CkB3iz7FVUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754513021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u+orTnNFFPf2x4JqpSoMjGvtPDbMPIatMYHdmq3y6Gs=; b=AU6CCcSfCqBztKHVG0qvanX4cfrUOzGA0TY3UlYNMeE0vRn5VSz3oHz/xW8UAlIZWZuIsX 4ayB/RoMtN9I5tkZep24TpYzF1i7f/6QG16RgJZ4k8Rz0puLXTOLwGi8lDUj3syxKg1Fbq lzxga+WVw8CbgZMmYOClbh413d98Bcn8I2Yd5HAJWwyS7hNeK+2jqSEop7mQ4bgC8leaaZ MxBdcTHzfljpLHHVSaCdJ8IaxxD1U0cXwA1iVxkKKKCOHwtVDL9pxE/aZFVSIOkXh6Pbla 5MaMsUAd9JqPd1cyqsLhXGmUSi/EFmITTUnwN9zWc+ZKvs4Bgx0km75AuxZ43Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754513021; a=rsa-sha256; cv=none; b=EfdNgW+CAHqPyDVgpKzmfQ5H2HSm+B3pZ7EG/iAFCia3A12Q5wWgWwE+eedttZC852EzUY H8YfY99U/TCIvRdGEy43aBd98To4ehs8xNLIlIqMhNsuXt9rxQyXUedx+kjWdfZE3qwSDQ vDxVqzjJROroR6VKqoOV+hMsVt89Joi2yG7wvt8Lp+Y5Fse9wf/MqgFQ80hb0dykhAw0JM E4lupGRxXIxCXRQKd8rsQHRDmLp5BE0OKf2fMto3bRLh+tFComzxN5xZPkgN59rDYoPXhV bnpZ+OdklxMzmwyqb33Xn8f6yyAlmDcqnHXI9wVWv0dVp3qsLdIHGGPaTrdqRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4by2M14Z5vzdCH; Wed, 06 Aug 2025 20:43:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 576KhfOB033660; Wed, 6 Aug 2025 20:43:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 576KhfVI033657; Wed, 6 Aug 2025 20:43:41 GMT (envelope-from git) Date: Wed, 6 Aug 2025 20:43:41 GMT Message-Id: <202508062043.576KhfVI033657@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: cc5276aed0c7 - main - libutil: Fix login_setcryptfmt() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cc5276aed0c779dedfe2603c746620ed9f3e97d2 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=cc5276aed0c779dedfe2603c746620ed9f3e97d2 commit cc5276aed0c779dedfe2603c746620ed9f3e97d2 Author: Dag-Erling Smørgrav AuthorDate: 2025-08-06 20:34:26 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-06 20:43:13 +0000 libutil: Fix login_setcryptfmt() Our dummy crypt_set_format() needs to be exported, otherwise it will be resolved at link time instead of load time, preventing the real crypt_set_format() in libcrypt from replacing it when present. PR: 288677 Fixes: 0c381b7f0570 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D51746 --- lib/libutil/Symbol.map | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map index 6b8a1ec099bf..2b28456f4406 100644 --- a/lib/libutil/Symbol.map +++ b/lib/libutil/Symbol.map @@ -120,6 +120,14 @@ FBSD_1.8 { uu_lock; uu_lockerr; uu_unlock; + + /* + * login_setcryptfmt() uses crypt_set_format() from libcrypt. To + * avoid forcing a hard dependency on libcrypt, we provide a weak + * stub. Applications that use login_setcryptfmt() should link + * with libcrypt, whose crypt_set_format() will override the stub. + */ + crypt_set_format; }; FBSDprivate_1.0 {