From owner-svn-src-all@freebsd.org Tue Sep 3 14:05:58 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DD9FDBF09; Tue, 3 Sep 2019 14:05:49 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7yh4ghGz4NsJ; Tue, 3 Sep 2019 14:05:48 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 0E6A219BF7; Tue, 3 Sep 2019 14:05:48 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 146BD10584; Thu, 28 Mar 2019 12:41:59 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3CA786ED46; Thu, 28 Mar 2019 12:41:58 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 17ABB10561; Thu, 28 Mar 2019 12:41:58 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id C87D61055A; Thu, 28 Mar 2019 12:41:54 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F6476ED30; Thu, 28 Mar 2019 12:41:54 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qt1-x842.google.com with SMTP id t28so22828394qte.6; Thu, 28 Mar 2019 05:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Rjp1BTYmDA5fUI1CUTPp6Voe9N2jvb0HpaxWIRaZKIU=; b=i5CgqtRh2NdgXH1KH+cf4rCP92jwXTo0xkpokKlchHleDpNSbr5OOKF3Vf+wOXahgh GrMBPZ4k/nXJRXU86y4ZzlLHIJwTl74k5s2AVhqoxlt5eipAZqRJXGoSBpdekK2gA9du uyheM4QIZRShsfkhBoY3P8RldJ+FFGhNvX0QmJIhlcD8II6wrtVepv/9VcCgPPE44A8n N37udl/QXctX9HHlpVTpzWuoyC6ZTbfiv0KjGZVTlnffq/A2aKT8G308IMyuG+CHGNJi iE1bzZxVRKws7yau7syX2/OeVhPurXsgKeab7/8ZPHaJAPH3wr0Yr8xjLPgcrhIY1aJr BI5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Rjp1BTYmDA5fUI1CUTPp6Voe9N2jvb0HpaxWIRaZKIU=; b=trxKAroswPe9zqPsGEUJ3lOJNY0Z3Iivbccq+DfaACI+/Z/VhG4mjGTk6N5KIzP/SJ 2StibiZlvpq5ACHB4KHxPGI/btYoKJCqujFFkZFCDXbM02f4e0ZeVL1A8j1j01/oqDJk 0e1uRn1nrUOt4zPhSo14kVEmE6DK5myG6Csah6NZKPYPDS84o4BEAtOiHtY5EfbVgJW9 I1XyTK1SR7NLyIFlrwqcffeuQvUyB3cA3Q/dv8H7qh2yjtvP1MTy+usuMUpPSyu+Gc7D 7p3evPPdkGoQ3Dw9j8zMImJDvHpj5PIX4eRvjxPS5M5c0IEFD1kdCBWLJKn3wJIadv3s oSBA== X-Gm-Message-State: APjAAAVI0fSHJBlAOMnEbK4WjdS8SPA/PZMBN0xvZrCIkxTfO4Ns6uZt By2pWXhe9KWD9ZUe4V+ELiYNWMit X-Google-Smtp-Source: APXvYqxlARrhru9JL6wWJwmwJ+Stk1VFE/dReF9Xvowr/IW/seg/dlXdylw6y+pygbBsNM0CYmmfkg== X-Received: by 2002:ac8:2cd6:: with SMTP id 22mr35892597qtx.112.1553776913490; Thu, 28 Mar 2019 05:41:53 -0700 (PDT) Received: from [172.21.4.121] (201-77-127-155.static.desktop.com.br. [201.77.127.155]) by smtp.gmail.com with ESMTPSA id p130sm13963696qka.96.2019.03.28.05.41.50 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 05:41:51 -0700 (PDT) Subject: Re: svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys To: Oliver Pinter , Ed Maste Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" References: <201903280212.x2S2CXoG000730@repo.freebsd.org> From: Renato Botelho Message-ID: <3d5e5264-bd98-7c57-b849-45affa974e1b@FreeBSD.org> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 3CA786ED46 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:05:58 -0000 X-Original-Date: Thu, 28 Mar 2019 09:41:49 -0300 X-List-Received-Date: Tue, 03 Sep 2019 14:05:58 -0000 On 3/28/19 4:25 AM, Oliver Pinter wrote: > On Thursday, March 28, 2019, Ed Maste wrote: > >> Author: emaste >> Date: Thu Mar 28 02:12:32 2019 >> New Revision: 345625 >> URL: https://svnweb.freebsd.org/changeset/base/345625 >> >> Log: >> revert r341429 "disable BIND_NOW in libc, libthr, and rtld" >> >> r345620 by kib@ fixed the rtld issue that caused a crash at startup >> during resolution of libc's ifuncs with BIND_NOW. >> >> PR: 233333 >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/contrib/elftoolchain/readelf/readelf.c >> head/lib/libc/Makefile >> head/lib/libthr/Makefile >> head/libexec/rtld-elf/Makefile >> head/sys/sys/elf_common.h >> >> Modified: head/contrib/elftoolchain/readelf/readelf.c >> ============================================================ >> ================== >> --- head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 01:12:44 2019 >> (r345624) >> +++ head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 02:12:32 2019 >> (r345625) >> @@ -3490,6 +3490,7 @@ dump_notes(struct readelf *re) >> >> static struct flag_desc note_feature_ctl_flags[] = { >> { NT_FREEBSD_FCTL_ASLR_DISABLE, "ASLR_DISABLE" }, >> + { NT_FREEBSD_FCTL_IMPLIED_MAX_PROT, "IMPLIED_MAX_PROT" }, >> { 0, NULL } >> }; >> >> > Seems like this and the other hunk belongs to a different patch. Indeed. It broke the build for me -- Renato Botelho