From nobody Mon Jul 29 19:25:50 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXpHf6XNXz5Rq3Y for ; Mon, 29 Jul 2024 19:26:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXpHf4Sqgz4b0Y for ; Mon, 29 Jul 2024 19:26:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-70ea2f25bfaso2426236b3a.1 for ; Mon, 29 Jul 2024 12:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1722281165; x=1722885965; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R5Jvyeb/iaPTjoiPT+i2BBsaujj/aoeIl+FcFt9ELEE=; b=D8m+e+GnkwaJsjn2Fyaj/No/DdP06UW622qTvqQv2JsZkQMHzuKtHYqx/lkqqxqFak FKsle9g4NaSff8+s0Vn92Xljri4ydyRTbOTAx93KU6U5p+oYKJKGv3AgNXDaKdyG38Sb +sNQvUi8Hp+pOnPSKvn6UjzJvd/J3nMKNbuKSXZKMFkldvUzq2tnIQzXv30FotBtxdt3 +4DqS4z/6A/QYZn59Nx+088faqBXVLDOsDLQB/RfeY6CN1q1FKH/CUSyH1KILorZGnm/ +5/RZi8EUt+4t553mi29NV0Z2zMG0f3HW+wfvN1E/12K5S0OM4bhAxYp94InTb0y10if P8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722281165; x=1722885965; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5Jvyeb/iaPTjoiPT+i2BBsaujj/aoeIl+FcFt9ELEE=; b=JaqIvDUCR6l9fhPdltO/CYCUaDae3MX07QWZZfa03VBbA1q43s8+3tF8o9kDUDxrvn mfhCFvB/h/B4EHWIbjXKUCf9ZWmClkH2irrhm+GHC3RqX88cOVqhyQ3b0c3eMfvs+fAZ qhdI7lWRR5p8lvZCDaX/m9INaOem84hnCf+tx5qJxpcoXfZ+3dDseFaoqV9Hdkry6YMQ 4J6MkLM1vYbDbjbM/Nr/oavQSzJrM7WJeWlHMXpYzY+DRBoxTn33ybftp7oeiQRXIX78 wkAYOlgQQv2fjzlMdy93V2K90CoGSCnN2joW60epOxR9NS3xJ9+AOt1t6AdsiZUrx3wd kjMg== X-Gm-Message-State: AOJu0Yw6oN/Lk2ZtXPcYNtpeqjVUTgYA7uff7u6rhofbm8sSPmrE/WS8 2vvHl2RpLkNaeRKjsjoW8NfyvoW4/CoRtzwtlXWEbfNk8gJr4TU5Te0Ms4m5YAn7BY1FOTU0vrh O/GR5OwxFW8mLSIxA8GoqBao4udyqBCseXTJOER40PAfMmdFOhq0= X-Google-Smtp-Source: AGHT+IFccO4oBBf8l5AalfYvkVtStoneyshh9xgjtuBPRCIRKFHEZqAAdLpTp9D342Re15IzXwmQDQ5dJb8kXJUDbZY= X-Received: by 2002:a05:6a20:432c:b0:1c0:f080:ed51 with SMTP id adf61e73a8af0-1c4a117959cmr7557318637.2.1722281165146; Mon, 29 Jul 2024 12:26:05 -0700 (PDT) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 29 Jul 2024 13:25:50 -0600 Message-ID: Subject: Re: /stand/i386/boot0/boot0.S and other boot files under i386 To: Bryce <678yym@gmail.com> Cc: freebsd-fs@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000d6388061e67d5f8" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WXpHf4Sqgz4b0Y --0000000000000d6388061e67d5f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable boot0.S is only for MBR. And really only loading the boot blocks from the start of a partition. pmbr.S is for GPT. It loads the freebsd-boot partition for the next stage. I'm biased against breaking compatibility generally, but might make an exception for a specific thing. What were you going to break? A lot depends on that... Warner On Mon, Jul 29, 2024 at 12:58=E2=80=AFPM Bryce <678yym@gmail.com> wrote: > Hello, list > > Ive been looking at boots.S and found some things that could use > improvement. I've changed a few things around here and there, but so far > have not broken compatibility in terms of appearance and interaction. > > How would the list feel about breaking compatibility? Would you all find > it acceptable if I was able to add features like booting from a logical > partition and adding error checking capabilities for the MBR (and thus th= e > ability to discern a GPT from MBR drive)? > > Last time there were any major changes seems to have been 20 years ago, > what does the list think? > --0000000000000d6388061e67d5f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
boot0.S is only for MBR. And really only loading the boot = blocks from the start of a partition.
pmbr.S is for GPT. It loads the f= reebsd-boot partition for the next stage.

I'm = biased against breaking compatibility generally, but might make an exceptio= n for a specific thing.

What were you going to bre= ak? A lot depends on that...

Warner
On Mon, J= ul 29, 2024 at 12:58=E2=80=AFPM Bryce <678yym@gmail.com> wrote:
Hello= , list

Ive been looking at boots.S and found= some things that could use improvement. I've changed a few things arou= nd here and there, but so far have not broken compatibility in terms of app= earance and interaction.
=
How would the list f= eel about breaking compatibility? Would you all find it acceptable if I was= able to add features like booting from a logical partition and adding erro= r checking capabilities for the MBR (and thus the ability to discern a GPT = from MBR drive)?

Last time there were any maj= or changes seems to have been 20 years ago, what does the list think?
=
--0000000000000d6388061e67d5f8--