From owner-svn-src-all@FreeBSD.ORG Mon Dec 12 10:14:45 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23A951065676; Mon, 12 Dec 2011 10:14:45 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id CFA638FC08; Mon, 12 Dec 2011 10:14:43 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA18466; Mon, 12 Dec 2011 12:14:42 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Ra2u9-000I4K-IX; Mon, 12 Dec 2011 12:14:42 +0200 Message-ID: <4EE5D40D.4070207@FreeBSD.org> Date: Mon, 12 Dec 2011 12:14:37 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111206 Thunderbird/8.0 MIME-Version: 1.0 To: Lawrence Stewart References: <201112120746.pBC7kAmF089105@svn.freebsd.org> <4EE5C787.9080905@freebsd.org> <4EE5CE54.3060401@freebsd.org> In-Reply-To: <4EE5CE54.3060401@freebsd.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228430 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2011 10:14:45 -0000 on 12/12/2011 11:50 Lawrence Stewart said the following: > On 12/12/11 20:21, Lawrence Stewart wrote: >> On 12/12/11 18:46, Andriy Gapon wrote: >>> Author: avg >>> Date: Mon Dec 12 07:46:10 2011 >>> New Revision: 228430 >>> URL: http://svn.freebsd.org/changeset/base/228430 >>> >>> Log: >>> kern_racct: move sys/systm.h inclusion to its proper place >>> >>> This should fix the build failure introduced with r228424. >>> Also remove duplicate inclusion of sys/param.h. >>> >>> Pointyhat to: avg >>> MFC after: 1 week >> >> >> lstewart@lstewart3:head> svn up >> Updating '.': >> At revision 228430. >> lstewart@lstewart3:head> make -DNO_CLEAN KERNCONF=LINT buildkernel >> [...] >> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -std=c99 -Wall >> -Wredundant-decls -Wnested-externs -Wstrict-prototypes >> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef >> -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs >> -fdiagnostics-show-option -nostdinc -I. >> -I/work/svn/freebsd_mirror/head/sys >> -I/work/svn/freebsd_mirror/head/sys/contrib/altq -D_KERNEL >> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common >> -finline-limit=8000 --param inline-unit-growth=100 --param >> large-function-growth=1000 -DGPROF -falign-functions=16 -DGPROF4 >> -DGUPROF -fno-builtin -fno-omit-frame-pointer -mno-sse -mcmodel=kernel >> -mno-red-zone -mno-mmx -msoft-float -fno-asynchronous-unwind-tables >> -ffreestanding -fstack-protector -Werror -pg -mprofiler-epilogue >> /work/svn/freebsd_mirror/head/sys/kern/kern_sx.c >> cc1: warnings being treated as errors >> In file included from /work/svn/freebsd_mirror/head/sys/kern/kern_sx.c:52: >> /work/svn/freebsd_mirror/head/sys/sys/sx.h: In function '__sx_xlock': >> /work/svn/freebsd_mirror/head/sys/sys/sx.h:154: warning: implicit >> declaration of function 'SCHEDULER_STOPPED' >> /work/svn/freebsd_mirror/head/sys/sys/sx.h:154: warning: nested extern >> declaration of 'SCHEDULER_STOPPED' [-Wnested-externs] >> *** Error code 1 >> >> Stop in /usr/obj/work/svn/freebsd_mirror/head/sys/LINT. >> *** Error code 1 >> >> Stop in /work/svn/freebsd_mirror/head. >> *** Error code 1 >> >> Stop in /work/svn/freebsd_mirror/head. >> >> >> >> Perhaps another place which needs a fix similar to r228430? > > Other files that also require fixing: > > sys/kern/vfs_cache.c > sys/security/mac/mac_framework.c > sys/security/mac/mac_priv.c Thank you. I should have tried to compile LINT myself :-( -- Andriy Gapon