From owner-cvs-all@FreeBSD.ORG Sun Sep 17 09:06:27 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 239E516A40F for ; Sun, 17 Sep 2006 09:06:27 +0000 (UTC) (envelope-from mime@traveller.cz) Received: from ss.eunet.cz (ss.eunet.cz [193.85.228.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9407543D46 for ; Sun, 17 Sep 2006 09:06:26 +0000 (GMT) (envelope-from mime@traveller.cz) Received: from localhost.i.cz (ss.eunet.cz [193.85.228.13]) by ss.eunet.cz (8.13.6/8.13.6) with ESMTP id k8H96Ki0038517 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sun, 17 Sep 2006 11:06:22 +0200 (CEST) (envelope-from mime@traveller.cz) From: Michal Mertl To: cvs-all@freebsd.org Content-Type: text/plain Date: Sun, 17 Sep 2006 11:06:13 +0200 Message-Id: <1158483973.72415.10.camel@genius.i.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: kostikbel@gmail.com Subject: Re: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Sep 2006 09:06:27 -0000 Konstantin Belousov wrote: > On Fri, Sep 08, 2006 at 01:09:24PM -0400, Jung-uk Kim wrote: > > On Friday 08 September 2006 10:59 am, Konstantin Belousov wrote: > > > kib 2006-09-08 14:59:55 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > libexec/rtld-elf rtld.c > > > Log: > > > When looking up the symbol by dlsym, look it not only in the > > > object given as dso handle, but also in the implicit dependencies > > > of that dso. > > > > > > Also, const-ify the read-only parameter objlist of symlook_list. > > > > > > Reported by: "Simon 'corecode' Schubert" > > tum de> Approved by: kan (mentor) > > > X-MFC-After: 6.2 > > > > > > Revision Changes Path > > > 1.117 +10 -13 src/libexec/rtld-elf/rtld.c > > > > I believe this warrants version number change for ports, IMO. > > This change brings rtld behaviour to the standard. Solaris and Linux both > do this in the right way. Shall we bump __FreeBSD_version for such kind of > bugfixes ? > > BTW, are you aware of ports that rely on old behaviour ? Evolution (2.6.3 built as part of gnome from ports, I have SYMVER_ENABLED=yes in /etc/make.conf) mostly stopped working after this commit (it starts but writes lots of error messages on stderr and the application menus are almost empty and it doesn't do anything). Reverting the change fixes it. Recompiling and reinstalling Evo didn't help. Thanks Michal