From owner-svn-src-head@FreeBSD.ORG Fri Nov 7 00:20:44 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B202A42D; Fri, 7 Nov 2014 00:20:44 +0000 (UTC) Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 323207CE; Fri, 7 Nov 2014 00:20:43 +0000 (UTC) Received: from secured.by.ipfw.ru ([95.143.220.47] helo=[10.0.0.120]) by mail.ipfw.ru with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82 (FreeBSD)) (envelope-from ) id 1XmTHa-000GZn-3K; Fri, 07 Nov 2014 00:03:50 +0400 Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Subject: Re: svn commit: r273112 - head/sys/dev/ixgbe From: "Alexander V. Chernikov" In-Reply-To: <20141107001507.GD17502@onelab2.iet.unipi.it> Date: Fri, 7 Nov 2014 03:20:39 +0300 Message-Id: <67A66ECA-2550-4ABE-8405-8EC332FB84DA@ipfw.ru> References: <201410150122.s9F1Mudu083306@svn.freebsd.org> <545B55FA.6070408@FreeBSD.org> <20141107001507.GD17502@onelab2.iet.unipi.it> To: Luigi Rizzo X-Mailer: Apple Mail (2.1990.1) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, Adrian Chadd , src-committers@freebsd.org, "Alexander V. Chernikov" , svn-src-all@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 00:20:44 -0000 > On 07 Nov 2014, at 03:15, Luigi Rizzo wrote: >=20 > On Thu, Nov 06, 2014 at 03:05:30PM +0400, Alexander V. Chernikov = wrote: >> On 15.10.2014 05:22, Adrian Chadd wrote: >>> Author: adrian >>> Date: Wed Oct 15 01:22:56 2014 >>> New Revision: 273112 >>> URL: https://svnweb.freebsd.org/changeset/base/273112 >>>=20 >>> Log: >>> Set the DROP_EN bit before the RX queue is brought up and active. >>>=20 >>> He noticed issues setting this bit in SRRCTL after the queue was = up, >>> so doing it from the sysctl handler isn't enough and may not = actually >>> work correctly. >> While investigating/measuring ixgbe performance w/ and without flow = control >> I noticed that disabling fc entirely (e.g. disabling 512K skid buffer=20= >> and turning drop_en on) >> not only makes things a bit worse, but also makes NIC stop accounting=20= >> tail-drops as errors >> at all. >> It is a bit unhandy with HW counters, since you, for example, see 2M=20= >> packets being received >> in netstat, but in reality system receives only 1M (And there is no = easy=20 >> way to determine exact >> count). >=20 > i'd like to point out that the default does not change (flow control > is still enabled by default) and the previous handling of DROP_EN The default did change: now drop_en is turned on by default due to a = small mistake (see my comment to commit). > was ineffective. >=20 > One may argue that FC and DROP_EN should be set independently, > and i am all for it. In fact that would be the right thing to do > in terms of POLA. >=20 > This said, i do not understand what kind of performance degradation > you experienced, can you be more specific ? Well, I haven=E2=80=99t tested it in great details, but for my = traditional shooting (IPv4 200 dsts to single rte) I observed some = notable change, like 9.2->8.6 MPPS or similar. I=E2=80=99m not insisting that something = should be done about it, since there is no silver bullet here. My point was that we=E2=80=99ve lost an ability to count ingress errors = in stock HEAD. >=20 > cheers > luigi