From owner-svn-ports-all@FreeBSD.ORG Fri Nov 30 02:53:02 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8EB7848D for ; Fri, 30 Nov 2012 02:53:02 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id E1D3B8FC14 for ; Fri, 30 Nov 2012 02:53:01 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so137867lbb.13 for ; Thu, 29 Nov 2012 18:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=adfagzLoCHqQNAit75eg9SxX+HO6luh4aXE3Vn4QUqc=; b=muYFzwaT79AL5mf6wAa1Iej6Pplu9XxsAWN5IGTbMVpL9aq6QVjlAuArC+qPBit8W/ 5no3CBfNlvJXGmybGH21UTDpCGs9zfKte4vOnxzSKIaph/KNtvgMQfZ0C0EaKa4wbFfY cdmtOHbuiO3TmTPGCabYlFn3n0vtt9keVTTe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=adfagzLoCHqQNAit75eg9SxX+HO6luh4aXE3Vn4QUqc=; b=ReziHDisa9h3LXSAQBuds6SurIQ65TaxsCCfBdX3TIIkL09V1LKhAUpAgSG+d6ACAR xSzSP/MYJ2xLz60wAtFNxQ4N0m99JRd6QFa9KM5fOTRn5GaupUt9npSAr//JufIb9WW2 ayrIUSNcCJgG19OiR+efcHSD1WV73GOTX42thUu21GTszzBaqrpgRbu8SalJkbSD+zPo dqTGYz+UHA/4SbwKxDCYF/Y7Gc1uvxPsu1ljpIKKT+/Xn5O4jxVYm8iS8pvJWL67fW0N RELOqDce4oWkFPUfocERC4wjxPYeVZBEgm09g7q0bhyKrMow11NCwS3QCNGZRH2oXMhw nNOQ== Received: by 10.152.103.100 with SMTP id fv4mr23350170lab.39.1354243980461; Thu, 29 Nov 2012 18:53:00 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Thu, 29 Nov 2012 18:52:30 -0800 (PST) In-Reply-To: <20121129133225.9e3dbd297872a7d3d8e949f5@FreeBSD.org> References: <201211281129.qASBT6Aw015051@svn.freebsd.org> <20121128213502.b5cd8fab508df17bad16c635@FreeBSD.org> <20121129133225.9e3dbd297872a7d3d8e949f5@FreeBSD.org> From: Eitan Adler Date: Thu, 29 Nov 2012 21:52:30 -0500 X-Google-Sender-Auth: HC2nSmlHMzfZJnisL6HwnybmIMQ Message-ID: Subject: Re: svn commit: r307902 - head/graphics/grafx2/files To: Emanuel Haupt Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnQajoQs7EFGyURjDsLkiZyMj7m8fKA4Ife5SEcmpbE+zL8MEFtsT/k87nGxzsB5koBFvjT Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 02:53:02 -0000 On 29 November 2012 07:32, Emanuel Haupt wrote: > Eitan Adler wrote: >> On 28 November 2012 15:35, Emanuel Haupt wrote: >> > Eitan Adler wrote: >> >> On 28 November 2012 06:29, Emanuel Haupt >> >> wrote: >> >> > Author: ehaupt >> >> > Date: Wed Nov 28 11:29:06 2012 >> >> > New Revision: 307902 >> >> > URL: http://svnweb.freebsd.org/changeset/ports/307902 >> >> > >> >> > Log: >> >> > Add patchfile. >> >> >> >> What does the patchfile do? Why is it needed? Was upstream >> >> contacted? >> >> >> >> - these should be documented in the log message. >> > >> > It is part of the update 2 minutes earlier. I thought this was >> > obvious. >> >> Ah, I didn't see this. In any case it would help to document these >> things - especially the part about whether upstream ACKed/NACKed the >> patch. > > You're right, I should have mentioned that in my follow up commit. The > patch has been submitted upstream. Haven't heard back so far. Thanks. My mail may have seemed unnecessarily strong. I just try to mention these things so people don't forget the next time. ~ Eitan - king of making mistakes :)