From owner-cvs-src@FreeBSD.ORG Mon Nov 20 18:43:17 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1458116A416; Mon, 20 Nov 2006 18:43:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F5A143D7F; Mon, 20 Nov 2006 18:41:03 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAKIf709077243; Mon, 20 Nov 2006 13:41:07 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Konstantin Belousov Date: Mon, 20 Nov 2006 12:30:56 -0500 User-Agent: KMail/1.9.1 References: <200611182059.kAIKxpBG080540@repoman.freebsd.org> In-Reply-To: <200611182059.kAIKxpBG080540@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611201230.56929.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 20 Nov 2006 13:41:07 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2207/Mon Nov 20 10:09:00 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/security/audit audit_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2006 18:43:17 -0000 On Saturday 18 November 2006 15:59, Konstantin Belousov wrote: > kib 2006-11-18 20:59:50 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/security/audit audit_syscalls.c > Log: > On RELENG_6, vn_open() will drop Giant aquired for calls into > non-MP-safe filesystem if fdx == -1, assuming the in-kernel callers are > not MP-safe. On HEAD, vn_open() after rev. 1.240 of sys/kern/vfs_vnops.c > would keep the Giant locked when the MPSAFE flag is given. > > The difference in the API caused the auditctl() syscall code to try to > unlock non-locked Giant for non-MP-safe filesystems, for instance, UFS > when QUOTA is compiled in. > > This is direct commit to RELENG_6 to accomodate for RELENG_6' vn_open(). > > Reported by: Steve Wills (steve at stevenwills com) > Reviewed by: rwatson > Approved by: re (bmah) > X-MFC to RELENG_6_2 after: 3 days Should probably MFC the vn_open() fixes to be honest, but that can be post 6.2. -- John Baldwin