From owner-svn-ports-all@freebsd.org  Wed Dec  6 17:52:22 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DFC8E874D8;
 Wed,  6 Dec 2017 17:52:22 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from fc.opsec.eu (fc.opsec.eu [IPv6:2001:14f8:200:4::4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 228687BE25;
 Wed,  6 Dec 2017 17:52:22 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from pi by fc.opsec.eu with local (Exim 4.89_1 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1eMdrl-00042M-By; Wed, 06 Dec 2017 18:52:17 +0100
Date: Wed, 6 Dec 2017 18:52:17 +0100
From: Kurt Jaeger <pi@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, hselasky@FreeBSD.org
Subject: Re: svn commit: r455665 - head/audio/zynaddsubfx
Message-ID: <20171206175217.GV68137@fc.opsec.eu>
References: <201712061730.vB6HU6hn021797@repo.freebsd.org>
 <20171206174407.GA82869@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171206174407.GA82869@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 17:52:22 -0000

Hi!

> > Log:
> >   audio/zynaddsubfx: fix build on cur, 10.x by force llvm40
> 
> Commit message does not explain what was the original problem, so it's
> hard to judge whether attempted solution is correct or not.

Yes, as usual the saying goes: look at the PR, and you'll find the
links to the build logs that failed. hps will probably dig into it
if he finds time.

> > @@ -41,8 +41,8 @@ GUI_LIB_DEPENDS=		libfltk.so:x11-toolkits/fltk \
> >  				libfontconfig.so:x11-fonts/fontconfig
> >  GUI_ON=				-DGuiModule:STRING=fltk
> >  GUI_CMAKE_OFF=			-DGuiModule:STRING=OFF
> > -GUI_USE+=			XORG=x11,xext,xfixes,xcursor,ice,sm,xpm,xinerama,xft
> > -GUI_USE+=			GL=glu
> > +GUI_USE+=			XORG=x11,xext,xfixes,xcursor,xrender,ice,sm,xpm,xinerama,xft
> > +GUI_USE+=			GL=gl,glu
> 
> This change was not explained in the commit log.

It was missing, we found that during testbuilds, and added it as well.

Would we add it if it would not be missing ?

> > +.include <bsd.port.options.mk>
> 
> What is this .include <bsd.port.options.mk> needed for?

hps added it, and so it went in. I doubt it's necessary, so hps
can remove it when he updates the port the next time.

> > +# Build fix for ZynAddSubFx
> > +BUILD_DEPENDS+=	clang40:devel/llvm40
> > +CC=		clang40
> > +CXX=		clang++40
> 
> ./danfe

-- 
pi@FreeBSD.org         +49 171 3101372                3 years to go !