From nobody Sun Sep 3 21:38:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rf4rP3VFKz4rl0h; Sun, 3 Sep 2023 21:38:13 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rf4rP2zWmz3J1r; Sun, 3 Sep 2023 21:38:13 +0000 (UTC) (envelope-from delphij@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693777093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GgkgbPmi6hJmRZBX5/Hnj72OOGq/7KohSiLJ6fjVpXw=; b=OZFjw1r3lp0fZ2YncPwMwux0lQ2CBkMf6K3nCB+n1GnArqgYx/TohMq+ig9ARLWV8sgFg5 vk9JBoyF7RGgqM0phce3wrsHJ7FWdbDY/juE5w23nonisgimgwv9it5nNm6uFMhkpgb7Oc Et/EXnUjv0JR0OdwbmyaE8iTyV4C1NbxFJ+UjLPMDBOrkLDwyZWFgdwNPWJ171jlKzToeL fJfBvrb26jrfpvYpBej921fyx0sE+SyXGgU0Yq+GhyrR7TIMmRuDppdGW45v2nHcTZp9uC 3iloStpyDnodgD0ASyls4JT8DQGyqIKDhhMhx1xxeX+J7sy/f9IKG0UGtlk6yw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693777093; a=rsa-sha256; cv=none; b=rgnmIyPEQ+/+m/frWKCN8vT9XoQgMtbk5uCVT0C1Ea0ZNIpOLTmuS9yZRaOgn3mUxyOhLN J8aKrMoYLbzMWnOgDfbL0BHoHkz4bhda897EanA0q02+W6Gg4hqVcKNyOJhgapCAnj/aLB WidvHQiKhPnHXSypJF/+7cEbM61cWvyLCNzN4XyrUIOdVjky+OKTgx6JCrizEcZyvfskpz JN2pbEvYD6iwKEuT5gS+uE3xFRBl5Q+bBzFXC7/gAZ6t5TobIG5+j4dGNYFNCbK0L8d5Ti mJXjM1FVX6LDs+LC8m3vMJaKJa+xRfy5XRMty2ZEl6ZLg3djziFCb9qLhoECdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693777093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GgkgbPmi6hJmRZBX5/Hnj72OOGq/7KohSiLJ6fjVpXw=; b=fDtnJ/EXmaFf+SiCMC0qnCYeqklZLqB1O9mrupT6TaSXs6iKTZpYYyWYpFpVO7dMxJJ8tQ YTIrTJyI8xBWL1fX3mbgsaApy6nJElk42HtGnLdgK/oBJ99euzvY8Q3i9xpARbJZkyKBdd L53LdmqK77Xod0ZqzyKqAok3s9MHyTxSOPVJLh+Wf5XfczliKD+LnYTYeZgfa//mzBVMTd ynfO6PsD00o7S2kotdf8r4YFvMdZwB7EsjpwxgRz4ZP8ho8kjEHipZnLHzy//s1NUE14JV BqINthxN/i87/CQ3hF04jHfycnD0GUkbILYx7CDPMmnqPzuiH2l9sf7at0oPIQ== Received: from [100.64.10.64] (unknown [141.193.140.240]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: delphij/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Rf4rN4wCSz17L; Sun, 3 Sep 2023 21:38:12 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Message-ID: <9cc70cf3-2ce5-e90c-dd53-de86dc6d2275@FreeBSD.org> Date: Sun, 3 Sep 2023 14:38:11 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Thunderbird Subject: Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13. Content-Language: en-US To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" References: <202309031849.383In8u2023677@gitrepo.freebsd.org> <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org> <1D25197C-63A0-429E-A7C9-5A662E29AD46@freebsd.org> From: Xin Li Organization: The FreeBSD Project In-Reply-To: <1D25197C-63A0-429E-A7C9-5A662E29AD46@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-09-03 1:30 PM, Jessica Clarke wrote: > On 3 Sep 2023, at 21:18, Xin Li wrote: >> >> On 2023-09-03 12:39 PM, Jessica Clarke wrote: >>> On 3 Sep 2023, at 19:49, Xin LI wrote: >>>> >>>> The branch stable/13 has been updated by delphij: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> >>>> commit 02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> Author: Xin LI >>>> AuthorDate: 2023-09-03 18:49:02 +0000 >>>> Commit: Xin LI >>>> CommitDate: 2023-09-03 18:49:02 +0000 >>>> >>>> Fix build for FreeBSD 13. >>>> >>>> The minigzip utility has been removed in FreeBSD 14 but still >>>> exists in FreeBSD 13. The upstream revision e9d5486e removed >>>> prototype definitions, rendering the code no longer compliant >>>> with WARNS=5. >>> Uh, what on earth is upstream doing? Has this been reported / >>> complained about? >> >> I've created a PR for this https://github.com/madler/zlib/pull/855 (by converting the functions to static ones). > > Oh, -Wmissing-prototypes, not calling a function without a prototype. > That’s not a big deal. Why not let WARNS stay as 5 but build with > -Wno-missing-prototypes? I didn't think it was worth the effort as the tool is not being used and is removed in FreeBSD 14, but to your point: https://reviews.freebsd.org/D41707