Date: Sun, 3 Sep 2023 14:38:11 -0700 From: Xin Li <delphij@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org> Subject: Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13. Message-ID: <9cc70cf3-2ce5-e90c-dd53-de86dc6d2275@FreeBSD.org> In-Reply-To: <1D25197C-63A0-429E-A7C9-5A662E29AD46@freebsd.org> References: <202309031849.383In8u2023677@gitrepo.freebsd.org> <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org> <f9e97e19-597d-c0ec-5a30-652a323b6cf4@FreeBSD.org> <1D25197C-63A0-429E-A7C9-5A662E29AD46@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2023-09-03 1:30 PM, Jessica Clarke wrote: > On 3 Sep 2023, at 21:18, Xin Li <delphij@FreeBSD.org> wrote: >> >> On 2023-09-03 12:39 PM, Jessica Clarke wrote: >>> On 3 Sep 2023, at 19:49, Xin LI <delphij@FreeBSD.org> wrote: >>>> >>>> The branch stable/13 has been updated by delphij: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> >>>> commit 02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> Author: Xin LI <delphij@FreeBSD.org> >>>> AuthorDate: 2023-09-03 18:49:02 +0000 >>>> Commit: Xin LI <delphij@FreeBSD.org> >>>> CommitDate: 2023-09-03 18:49:02 +0000 >>>> >>>> Fix build for FreeBSD 13. >>>> >>>> The minigzip utility has been removed in FreeBSD 14 but still >>>> exists in FreeBSD 13. The upstream revision e9d5486e removed >>>> prototype definitions, rendering the code no longer compliant >>>> with WARNS=5. >>> Uh, what on earth is upstream doing? Has this been reported / >>> complained about? >> >> I've created a PR for this https://github.com/madler/zlib/pull/855 (by converting the functions to static ones). > > Oh, -Wmissing-prototypes, not calling a function without a prototype. > That’s not a big deal. Why not let WARNS stay as 5 but build with > -Wno-missing-prototypes? I didn't think it was worth the effort as the tool is not being used and is removed in FreeBSD 14, but to your point: https://reviews.freebsd.org/D41707
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9cc70cf3-2ce5-e90c-dd53-de86dc6d2275>