From owner-freebsd-stable@FreeBSD.ORG Wed Jun 16 05:53:23 2010 Return-Path: Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE9A2106566C for ; Wed, 16 Jun 2010 05:53:23 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84]) by mx1.freebsd.org (Postfix) with ESMTP id 81AA28FC15 for ; Wed, 16 Jun 2010 05:53:23 +0000 (UTC) Received: from pampa.cs.huji.ac.il ([132.65.80.32]) by kabab.cs.huji.ac.il with esmtp id 1OOlYo-000Fi2-WC; Wed, 16 Jun 2010 08:53:15 +0300 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: d@delphij.net In-reply-to: <4C18195A.3020501@delphij.net> References: <1276639800.2462.80.camel@localhost.localdomain> <1276646707.2462.82.camel@localhost.localdomain> <4C18195A.3020501@delphij.net> Comments: In-reply-to Xin LI message dated "Tue, 15 Jun 2010 17:22:50 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 16 Jun 2010 08:53:14 +0300 From: Daniel Braniss Message-ID: Cc: "delphij@freebsd.org" , "freebsd-stable@freebsd.org" , Sean Bruno Subject: Re: [Stable 7] CPIO breakage/ X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 05:53:23 -0000 > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 2010/06/15 17:05, Sean Bruno wrote: > > On Tue, 2010-06-15 at 17:10 -0500, Sean Bruno wrote: > >> http://svn.freebsd.org/viewvc/base?limit_changes=0&view=revision&revision=208361 > >> > >> I'm not sure what's up with this update, but it hosed up the default > >> behavior of cpio. > >> > >> It appears now that -o won't do the same things that it used to: > >> > >> + cd / > >> + find -x . > >> + egrep -v '^\.(/snap|/usr/sup|/boot/kernel/kernel > >> \.[[:alpha:]_]+\.[[:digit:]]+|/boot/kernel/kernel > >> \.old|/etc/start_if.*|/etc/ssh/ssh_host_.*key|/etc/hostid|/etc/(master.passwd|passwd|spwd.db|pwd.db))' > >> + '[' -n '' ']' > >> + '[' 7 = 4 ']' > >> + '[' -n '' -a -z '' ']' > >> + '[' -n /home/backup ']' > >> + echo 'dumping / ...' > >> dumping / ... > >> + cpio -o --quiet --format crc -O /home/backup/root.amd64.cpio > >> cpio: ./dev not dumped: minor number would be truncated > >> cpio: Removing leading `/' from member names > >> cpio: ./proc not dumped: minor number would be truncated > >> cpio: Removing leading `../' from member names > >> > >> We've had to revert this change from our local tree, suggestions? > >> > >> Sean > > > > > > A little more background. It looks like symlinks are getting stripped > > of their '/' which sucks. Ideas? > > > > Sean > > > > e.g. /home/foo/bar -> /opt/baz/blob > > > > becomes > > > > home/foo/bar -> opt/baz/blob > > > > Yuck. > > This is a security measurement I think. > > - --absolute-filenames disables this behavior. A similar 'security feature' was introduced sometime ago, wich 'silently' broke firefox instalation , it refused to allow symlinks in destination directory, of course the error was ignored by 'make install' so it took some time later to find out that nothing was installed - my /usr/local is symlinked. The solution was to 'fix' cpio to behave as before, since adding the ignore-symlinks feature to firefox's makefile was beyond me :-) danny