Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Aug 2020 19:36:56 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r546857 - in head/www: . gallery-dl
Message-ID:  <ft82-3efb-wny@FreeBSD.org>
In-Reply-To: <20200831161326.qsxkqltwwr72yqdi@aching.in.mat.cc> (Mathieu Arnold's message of "Mon, 31 Aug 2020 18:13:26 %2B0200")
References:  <202008290038.07T0cS3d064005@repo.freebsd.org> <20200831161326.qsxkqltwwr72yqdi@aching.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@freebsd.org> writes:

> On Sat, Aug 29, 2020 at 12:38:28AM +0000, Jan Beich wrote:
>
>> +post-build:
>> +# USE_GITHUB archive doesn't have generated files
>> +	@${DO_MAKE_BUILD} -C ${BUILD_WRKSRC} PYTHON="${PYTHON_CMD}" man completion
>
> As the author also provides a working tarball, why use the incomplete github archive?
>
> https://github.com/mikf/gallery-dl/releases/download/v1.14.5/gallery_dl-1.14.5.tar.gz

Easier to test snapshots or apply upstream fixes and better reproducibility.

One could drop USE_PYTHON=distutils and build via make(1) a la www/youtube_dl
but I didn't like it because calling setup.py manually is error-prone.
For example, www/youtube_dl doesn't precompile *.py files.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ft82-3efb-wny>