From owner-cvs-all Thu Sep 6 19:25:35 2001 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id DB01D37B406; Thu, 6 Sep 2001 19:25:27 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 9A4A981D05; Thu, 6 Sep 2001 21:25:27 -0500 (CDT) Date: Thu, 6 Sep 2001 21:25:27 -0500 From: Alfred Perlstein To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio stdio.c Message-ID: <20010906212527.W81307@elvis.mu.org> References: <200109070213.f872DCa19917@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200109070213.f872DCa19917@freefall.freebsd.org>; from ache@FreeBSD.org on Thu, Sep 06, 2001 at 07:13:11PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Andrey A. Chernov [010906 21:13] wrote: > ache 2001/09/06 19:13:11 PDT > > Modified files: > lib/libc/stdio stdio.c > Log: > For now just back out seek error checking in __SAPP case, it cause problems > with non-seekable streams. Now here is what here was originally, but it is > ugly, producing unneded seek syscall on each non-seekable stream write. I'll > think about proper solution later. Both revisions did basically the same thing, except that the previous change you did broke things. One way to fix this would be to record the failed lseek returning EISPIPE and noting that the backing object is not seekable, from then on you could avoid the unnescesary syscalls. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message