From owner-svn-src-all@freebsd.org Mon Jul 3 05:30:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D4F69DE5F2; Mon, 3 Jul 2017 05:30:33 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0952182BDC; Mon, 3 Jul 2017 05:30:32 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v635UWYR011922; Mon, 3 Jul 2017 05:30:32 GMT (envelope-from delphij@FreeBSD.org) Received: (from delphij@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v635UWYw011921; Mon, 3 Jul 2017 05:30:32 GMT (envelope-from delphij@FreeBSD.org) Message-Id: <201707030530.v635UWYw011921@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: delphij set sender to delphij@FreeBSD.org using -f From: Xin LI Date: Mon, 3 Jul 2017 05:30:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r320587 - stable/10/usr.sbin/rpc.lockd X-SVN-Group: stable-10 X-SVN-Commit-Author: delphij X-SVN-Commit-Paths: stable/10/usr.sbin/rpc.lockd X-SVN-Commit-Revision: 320587 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 05:30:33 -0000 Author: delphij Date: Mon Jul 3 05:30:31 2017 New Revision: 320587 URL: https://svnweb.freebsd.org/changeset/base/320587 Log: MFC r320093: Check return value of seteuid() and bail out if we fail. Modified: stable/10/usr.sbin/rpc.lockd/lock_proc.c Directory Properties: stable/10/ (props changed) Modified: stable/10/usr.sbin/rpc.lockd/lock_proc.c ============================================================================== --- stable/10/usr.sbin/rpc.lockd/lock_proc.c Mon Jul 3 05:22:10 2017 (r320586) +++ stable/10/usr.sbin/rpc.lockd/lock_proc.c Mon Jul 3 05:30:31 2017 (r320587) @@ -283,7 +283,10 @@ get_client(host_addr, vers) /* Regain root privileges, for bindresvport. */ old_euid = geteuid(); - seteuid(0); + if (seteuid(0) != 0) { + syslog(LOG_ERR, "seteuid(0) failed"); + return NULL; + } /* * Bind the client FD to a reserved port. @@ -292,7 +295,10 @@ get_client(host_addr, vers) bindresvport(clnt_fd, NULL); /* Drop root privileges again. */ - seteuid(old_euid); + if (seteuid(old_euid) != 0) { + syslog(LOG_ERR, "seteuid(%d) failed", old_euid); + return NULL; + } /* Success - update the cache entry */ clnt_cache_ptr[clnt_cache_next_to_use] = client;