From owner-cvs-all@FreeBSD.ORG Thu Jul 27 18:06:30 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0435716A4E0; Thu, 27 Jul 2006 18:06:30 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEADA43D49; Thu, 27 Jul 2006 18:06:27 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6RI6MNN007060; Thu, 27 Jul 2006 22:06:22 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6RI6MsN007059; Thu, 27 Jul 2006 22:06:22 +0400 (MSD) (envelope-from yar) Date: Thu, 27 Jul 2006 22:06:21 +0400 From: Yar Tikhiy To: Hajimu UMEMOTO Message-ID: <20060727180621.GB5075@comp.chem.msu.su> References: <200607271326.k6RDQTBt081170@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/route Makefile src/sbin/rtsol Makefile src/sbin/setkey Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2006 18:06:30 -0000 On Fri, Jul 28, 2006 at 12:06:15AM +0900, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Thu, 27 Jul 2006 13:26:29 +0000 (UTC) > >>>>> Yar Tikhiy said: > > yar> yar 2006-07-27 13:26:29 UTC > > yar> FreeBSD src repository > > yar> Modified files: > yar> sbin/route Makefile > yar> sbin/rtsol Makefile > yar> sbin/setkey Makefile > yar> Log: > yar> Obey MK_INET6_SUPPORT. > yar> This is also a good chance to apply style.Makefile(5) in some cases. > > rtsol is a utility only for IPv6, and INET6 is not referred from rtsol > sources. Since INET6 might be reffered from include files, -DINET6 is > required, here. So, building rtsol without -DINET6 is not good. You > may want to exclude rtsol from building by src/sbin/Makefile, instead. Thank you, I obviously missed that. I've just found that rtsol doesn't depend on INET6 at all (the binary stays the same,) so I've fixed Makefiles for sbin/rtsol and sbin accordingly. P.S. I don't think that any conventional include files should depend on INET6 either. Some of our /usr/include files refer to INET6, but they do from their kernel-specific parts only. -- Yar