Date: Tue, 22 Jul 2003 19:10:18 -0700 (PDT) From: Munish Chopra <mchopra@engmail.uwaterloo.ca> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/54671: audio/abcde-2.1.4 system config file path fix Message-ID: <200307230210.h6N2AI3w059344@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/54671; it has been noted by GNATS. From: Munish Chopra <mchopra@engmail.uwaterloo.ca> To: "Bjoern A. Zeeb" <bzeeb+freebsdports@zabbadoz.net> Cc: "Sergey A. Osokin" <osa@FreeBSD.org>, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/54671: audio/abcde-2.1.4 system config file path fix Date: Tue, 22 Jul 2003 22:05:12 -0400 On 2003-07-21 16:15 +0000, Bjoern A. Zeeb wrote: > On Mon, 21 Jul 2003, Sergey A. Osokin wrote: > > Hi, > > > > -in this file override those in /etc/abcde.conf or $HOME/.abcde.conf. > > > +in this file override those in /usr/local/etc/abcde.conf or $HOME/.abcde.conf. > > ^^^^^^^^^^^^^^^^^^^ not right. > > Use %%PREFIX/etc/bla-bla-bla instead of hardcoded path. > > this brings us to where I had been with abcde-2.1.2. Most likely those > changes had been missed and not - what I first thought - dropped so do > it that way again: > > o one new file: files/patch-ab > > --- patch for Makfile --- > --- Makefile.orig Mon Jul 21 16:09:36 2003 > +++ Makefile Mon Jul 21 16:10:12 2003 > @@ -67,6 +67,14 @@ > @${ECHO_MSG} "" > .endif > > +post-patch: > + @${CP} ${WRKSRC}/abcde.1 ${WRKSRC}/abcde.1.orig > + @${SED} -e 's#@PKG_SYSCONFDIR@#${PREFIX}/etc#g' \ > + ${WRKSRC}/abcde.1.orig > ${WRKSRC}/abcde.1 > + @${CP} ${WRKSRC}/abcde ${WRKSRC}/abcde.orig > + @${SED} -e 's#@PKG_SYSCONFDIR@#${PREFIX}/etc#g' \ > + ${WRKSRC}/abcde.orig > ${WRKSRC}/abcde > + [...] I was assuming %%PREFIX like Sergey was, but if what you're doing is The Right Thing(TM), I've got no problem with it. I'll bug the author for an upstream change later, if at all. I'd have to see how it could work through some Makefile magic I suppose. Thanks for the patch. -- Munish Chopra
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200307230210.h6N2AI3w059344>