From owner-cvs-all@FreeBSD.ORG Wed Dec 15 14:21:21 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68D2416A4CE; Wed, 15 Dec 2004 14:21:21 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2757643D31; Wed, 15 Dec 2004 14:21:20 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBFELIOx020778; Wed, 15 Dec 2004 16:21:18 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 47218-18; Wed, 15 Dec 2004 16:21:13 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBFELBLt020761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 15 Dec 2004 16:21:12 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iBFELExn029317; Wed, 15 Dec 2004 16:21:14 +0200 (EET) (envelope-from ru) Date: Wed, 15 Dec 2004 16:21:14 +0200 From: Ruslan Ermilov To: Tom Rhodes Message-ID: <20041215142114.GA24846@ip.net.ua> References: <200412150210.iBF2AodY094280@repoman.freebsd.org> <20041215084901.GC25967@ip.net.ua> <20041215083548.5455ea2c@localhost> <20041215135230.GA2319@ip.net.ua> <20041215090139.53a90960@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline In-Reply-To: <20041215090139.53a90960@localhost> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2004 14:21:21 -0000 --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2004 at 09:01:39AM -0500, Tom Rhodes wrote: > On Wed, 15 Dec 2004 15:52:30 +0200 > Ruslan Ermilov wrote: >=20 > > On Wed, Dec 15, 2004 at 08:35:48AM -0500, Tom Rhodes wrote: > > > On Wed, 15 Dec 2004 10:49:01 +0200 > > > Ruslan Ermilov wrote: > > >=20 > > > > On Wed, Dec 15, 2004 at 02:10:50AM +0000, Tom Rhodes wrote: > > > > > trhodes 2004-12-15 02:10:50 UTC > > > > >=20 > > > > > FreeBSD src repository > > > > >=20 > > > > > Modified files: > > > > > share/examples/etc make.conf=20 > > > > > Log: > > > > > Add a few options with regards to ppp(8) and traceroute. > > > > > Sort the list, please keep this list sorted. > > > > > =20 > > > > > PR: 48569 > > > > > =20 > > > > > Revision Changes Path > > > > > 1.241 +17 -11 src/share/examples/etc/make.conf > > > > >=20 > > > > You unsorted the list, please fix. The correct sorting > > > > order here is in "dictinary order", please see sort(1). > > >=20 > > > Hold on a minute. A good while ago someone (bde? you? other?) > > > told me that these options should be sorted by dictionary order > > > only after the separation of "NOFOO" and "NO_FOO." Am I lost > > > or something? > > >=20 > > You're lost. I fixed this some time ago (in my latest commit > > to this file), and now you disordered it again. ;) >=20 > cvs log make.conf | grep -A 10 'trhodes' > ------------------------------------------- > date: 2003/02/14 20:04:44; author: trhodes; state: Exp; lines: +1 -1 > Move NOMAN down the section without underscore characters. > Add a forgotten `=3D' sign. >=20 > Thanks to: ru, bde > ------------------------------------------ >=20 > Remember that thread? Something about bad sorting of NOMAN > (dictionary format correct but should not be in with the > underscored variables). >=20 In the time of that commit (rev. 1.209), the underscored versions were separated from non-underscored ones. This time (rev. 1.240), they were merged and sorted in dictionary order (for easier human search). You should have preserved the existing style. I don't see any controversy between these two revisions (rev. 1.211 and the upcoming revision when you commit my patch ;), both use the rule "don't break an existing style". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwEhaqRfpzJluFF4RAls/AKCVPWnOVVF1B8f7c83LnA0sbVEmtQCffZDq hzjEK0zyQbG4SM6Vhqs+5l8= =MPhb -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24--