From owner-freebsd-net@freebsd.org Thu Jul 16 06:19:08 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E4D6D35714C for ; Thu, 16 Jul 2020 06:19:08 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B6kbw0XLqz45H7; Thu, 16 Jul 2020 06:19:07 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 06G6J0pC011907 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Jul 2020 06:19:03 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: D25681+519+66d99c87edb3146d@reviews.freebsd.org Received: from [10.58.0.10] (dadv@dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id 06G6Itnq078111 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 16 Jul 2020 13:18:55 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: [Differential] D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options To: "neel_neelc.org (Neel Chauhan)" , "freebsd-net@freebsd.org" , Ed Maste , rik@FreeBSD.org, serge.vakulenko@gmail.com References: <63119e9c795d8f1391a26bfc1fe02671@localhost.localdomain> From: Eugene Grosbein Message-ID: <113798ad-cf0f-396b-fc4d-cf55f9ea0862@grosbein.net> Date: Thu, 16 Jul 2020 13:18:44 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <63119e9c795d8f1391a26bfc1fe02671@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 2.6 LOCAL_FROM From my domains * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4B6kbw0XLqz45H7 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [1.73 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.19)[-0.187]; TAGGED_RCPT(0.00)[519,66d99c87edb3146d]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_PERMFAIL(0.00)[empty SPF record]; NEURAL_SPAM_LONG(0.60)[0.595]; NEURAL_HAM_SHORT(-0.07)[-0.074]; FREEMAIL_TO(0.00)[reviews.freebsd.org,freebsd.org,FreeBSD.org,gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 06:19:09 -0000 CCing Roman Kurakin (ce(4)) and Serge Vakulenko (cp(4)), see later. 16.07.2020 9:23, neel_neelc.org (Neel Chauhan) wrote: > neel_neelc.org abandoned this revision. > > REPOSITORY > rS FreeBSD src repository > > CHANGES SINCE LAST ACTION > https://reviews.freebsd.org/D25681/new/ > > REVISION DETAIL > https://reviews.freebsd.org/D25681 I wonder if we really have use cases for sppp(4)/ng_sppp(4) these days. This code was created in 199x to support some synchronous Cronyx adapters and their drivers: ce(4) for PCI G.703/E1 card, cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards, and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore, removed by emaste@ recently. Both ce(4) and cp(4) are i386-only drivers at present. I could not find any other consumers of sppp code in base system and I doubt there are outside base, but I may be wrong. I'd like to see some comments from rik and vak, though.