From nobody Mon Nov 1 17:14:43 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B06FE1836EB1; Mon, 1 Nov 2021 17:14:46 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hjfm64RMSz4WtN; Mon, 1 Nov 2021 17:14:46 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from mandree.no-ip.org (p200300d02727640067ce6a549f769569.dip0.t-ipconnect.de [IPv6:2003:d0:2727:6400:67ce:6a54:9f76:9569]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 5AEEA28E67; Mon, 1 Nov 2021 17:14:46 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id D1C89120644; Mon, 1 Nov 2021 18:14:43 +0100 (CET) Message-ID: <47bc0bef-ca47-d62f-d4a2-e3f4db462fe7@FreeBSD.org> Date: Mon, 1 Nov 2021 18:14:43 +0100 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Content-Language: en-US To: Christian Weisgerber , Alexey Dokuchaev Cc: Piotr Kubaj , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202111010243.1A12hxQj066278@gitrepo.freebsd.org> From: Matthias Andree Subject: Re: git: c6c6e67d83c2 - main - audio/flac: don't disable VSX on powerpc64le In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N Am 01.11.21 um 13:54 schrieb Christian Weisgerber: > Alexey Dokuchaev: > >> I wonder why SSE was disabled in 101cb31e18d13 during the update to >> version 1.3.2, as it was never explained: >> ... >> CONFIGURE_ARGS= --enable-static \ >> - --enable-sse \ >> + --disable-sse \ > > --enable-sse simply adds "-msse2" to the compiler flags. > > On amd64, this is a nop, since SSE2 is part of the amd64 architecture. > On i386, it generates code that won't run on older CPUs that don't > support SSE2. Yeah - do we care? SSE2 has come of age in most legislations :-) Perhaps you need to force -mstackrealign (at least on GCC) with -msse2 on i386 and if you really need to support museal CPUs, make SSE an option and default it to enabled. Or maybe a -nosse flavor. I had been considering SSE2 for rawtherapee as well, and as a result, I have had this in ports/graphics/rawtherapee/Makefile. It used to be an option into early 2019, but aside from one irrelevant complaint of someone who was trying to argue me out of LTO with -O3 for rawtherapee's heavy lifting ^W^W number crunching, no complaints. graphics/rawtherapee/Makefile excerpt: --------->8------------------------------------------------------------- .include # ... # x86_64/amd64 includes -msse2 by default .if ${ARCH} == i386 # and SSE2 has been around since the year 2003 latest _OPT_FLAGS+= -msse2 .endif # workaround for values passed on the stack that cause SIGBUS on SSE2 .if ${ARCH} == i386 _OPT_FLAGS+= -mstackrealign .endif .include # ... ---------8<-------------------------------------------------------------