From owner-freebsd-hackers  Tue Mar  4 17:26: 7 2003
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2218837B401
	for <freebsd-hackers@freebsd.org>; Tue,  4 Mar 2003 17:26:06 -0800 (PST)
Received: from c001.snv.cp.net (h021.c001.snv.cp.net [209.228.32.135])
	by mx1.FreeBSD.org (Postfix) with SMTP id 6CC9843FBD
	for <freebsd-hackers@freebsd.org>; Tue,  4 Mar 2003 17:26:05 -0800 (PST)
	(envelope-from kutulu@kutulu.org)
Received: (cpmta 23859 invoked from network); 4 Mar 2003 17:26:04 -0800
Received: from 64.212.128.3 (HELO kutulu)
  by smtp.register-admin.com (209.228.32.135) with SMTP; 4 Mar 2003 17:26:04 -0800
X-Sent: 5 Mar 2003 01:26:04 GMT
Message-ID: <01be01c2e2b6$30742b00$29330f0a@lcapps.educate.com>
From: "Mike Edenfield" <kutulu@kutulu.org>
To: <freebsd-hackers@freebsd.org>
Subject: D_KQFILTER & ltmdm: Patch for review?
Date: Tue, 4 Mar 2003 20:26:03 -0500
Organization: KutuluWare Software Services
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Sent: Tuesday, March 04, 2003 5:39 PM

> But your patch is wrong.  Please format the initialization like
> you see in all the other device drivers:

I now see what you meant about the formatting.  It was the whole reason to
reorder the fields, sorry I missed that.  I also removed the redundant
initializations.

Do you (well, does anyone) have a moment to eyeball this patch before I send
it off to the maintainer?

Thanks again,

--Mike

--- sys/dev/ltmdm/ltmdmsio.c.orig       Tue Mar  4 19:49:57 2003
+++ sys/dev/ltmdm/ltmdmsio.c    Tue Mar  4 20:17:16 2003
@@ -360,6 +360,18 @@
 #endif

 static struct cdevsw sio_cdevsw = {
+#if __FreeBSD_version >= 500104 /* >= 20030303 */
+       .d_maj = MAJOR_AUTO,
+       .d_flags = D_TTY,
+       .d_name = driver_name,
+       .d_open = sioopen,
+       .d_close = sioclose,
+       .d_read = sioread,
+       .d_write = siowrite,
+       .d_ioctl = sioioctl,
+       .d_poll = ttypoll,
+       .d_kqfilter = ttykqfilter
+#else
     /* open */  sioopen,
     /* close */ sioclose,
     /* read */  sioread,
@@ -389,6 +401,7 @@
     /* kqfilter */  ttykqfilter,
 #endif
 #endif
+#endif /* __FreeBSD_version >= 500104 */
 };

 static  u_int   com_events; /* input chars + weighted output completions */


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message