From owner-freebsd-current Sat Mar 8 11:41:47 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B16937B401 for ; Sat, 8 Mar 2003 11:41:46 -0800 (PST) Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B6B843FCB for ; Sat, 8 Mar 2003 11:41:45 -0800 (PST) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp4.server.rpi.edu (8.12.8/8.12.7) with ESMTP id h28JfguF005842; Sat, 8 Mar 2003 14:41:42 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: <20030308161943.GA54921@attbi.com> <200303081728.h28HSDWM039984@khavrinen.lcs.mit.edu> <20030308184834.GC543@dhcp01.pn.xcllnt.net> Date: Sat, 8 Mar 2003 14:41:41 -0500 To: Marcel Moolenaar , Garrett Wollman From: Garance A Drosihn Subject: Re: #warning must be protected by #if __GNUC__ in headers? Cc: Craig Rodrigues , freebsd-current@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.28 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 2:33 PM -0500 3/8/03, Garance A Drosihn wrote: > >By adding that #warning, you are going to have a compile-time error >on some compilers, whether or not you want it. Hiding it inside of >an #if/#endif will help for some compilers, but not on all of them. Er, I should note that I do like the idea of using #warnings for some things. All I meant to say was that I would not waste my time putting it inside of a #if __GNUC__. GNUC is not the only compiler which understands it, and for some of the compilers which do not understand it, you're still going to get a compile-time error even if it's inside that #if/#endif. By putting it inside #if __GNUC__, you're just confusing things by making it look like the warning itself is *because of* GCC. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message