From owner-freebsd-current@freebsd.org Mon Mar 29 17:27:11 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFBA557E0E4; Mon, 29 Mar 2021 17:27:11 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F8KJb0dB9z4RHk; Mon, 29 Mar 2021 17:27:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qk1-f174.google.com with SMTP id c4so13178653qkg.3; Mon, 29 Mar 2021 10:27:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qZcSpNG2kMEvB1mfVUj7DobHVkuVAskIqb6kRM+bA/w=; b=jvaEUq1B5TXHwI5JHl8V5qtkjWcbboYV24AvqrpkX/yrnwopyvuzMagaji55oWDz85 LIkxWN3Ika26/nrhwUWF8lq/lAabiRppjVlRWFE4eZ1J4mq7oMLEt3tQsuGWXVMb7liJ GIDt/AcBmzkgcGQET5eFQvE/f0wiEkia20tgswhk6sKRkolB84kT15NwvRTawV2Sestc tlHpd8iAxB/KWKRoPqKE0GxXo6n65HPtCHKzYrN8cmOTHdlHwRGqH2iwtDzTFP3TThIN GmqAnt75AQ4/TKnXIg/sXaFxGZtExI0sNwun4DbbJHnH74wxtBH6FZEWMJVAbFcZlqxB 8PKw== X-Gm-Message-State: AOAM532PLTcRrjkHfQOhQ7DEx8Q0BdyVmWZonhCr0gjRKmCHweqienMc 8D/o6RRpqBK/0Yl7MSMtYPp2G4kWLkjZzKY8orkyoWMRFKc= X-Google-Smtp-Source: ABdhPJxcmGo7EjjLpMNZIJB6Q8DV2h/9HrtSOwdJa1XgnB5BbdIIm+xaQS35zr6kv6g/FwmhbhZNR/5LJDie+15l8Xk= X-Received: by 2002:a05:620a:11ad:: with SMTP id c13mr26329037qkk.282.1617038830150; Mon, 29 Mar 2021 10:27:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Mon, 29 Mar 2021 10:26:58 -0700 Message-ID: Subject: Re: Correct net80211 channel flag. To: qcwap <1051244836@qq.com>, freebsd-wireless Cc: freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4F8KJb0dB9z4RHk X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of adrianchadd@gmail.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=adrianchadd@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.70)[-0.697]; FREEMAIL_TO(0.00)[qq.com,freebsd.org]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.222.174:from]; R_DKIM_NA(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.222.174:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.174:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.174:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-wireless,freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 17:27:11 -0000 hm! On Mon, 29 Mar 2021 at 08:02, qcwap <1051244836@qq.com> wrote: > > This patch corrects ieee80211_vht_get_vhtcap_ie for 160/80P80 channel width recognition. > > diff --git a/sys/net80211/ieee80211.h b/sys/net80211/ieee80211.h > index 86ab1459cca..76c43629b33 100644 > --- a/sys/net80211/ieee80211.h > +++ b/sys/net80211/ieee80211.h > @@ -811,9 +811,9 @@ struct ieee80211_ie_vht_operation { > #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK 0x0000000C > #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK_S 2 > #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_NONE 0 > -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 1 > -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 2 > -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 3 > +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 4 > +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 8 > +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 16 > > #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ(_vhtcaps) \ > (_IEEE80211_MASKSHIFT(_vhtcaps, IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK) >= \ This is the flag change from the draft 11ac spec to the released 11ac spec, right? I remember they needed to change the flags because existing draft implementations got the 80+80/160MHz negotiation really badly wrong in some interop places... -adrian > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"