From owner-freebsd-current@FreeBSD.ORG Mon Jul 11 23:36:20 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D70E7106564A for ; Mon, 11 Jul 2011 23:36:20 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 868478FC0C for ; Mon, 11 Jul 2011 23:36:20 +0000 (UTC) Received: by qyk38 with SMTP id 38so2872167qyk.13 for ; Mon, 11 Jul 2011 16:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=9X5O1Hegjju9ODiVyxszEGUWk5/qjg0lESDJwNMvva8=; b=bSC2qzvMIKcOu5sMkiNWMYIpt4xapytHSTodTJCqElC7F4OqR1hsqRYLpBvryNQkeS Dbv/6WmxpxYlWPei1Dm7UKtsHfgx9ZO840mAMUtk+hrKmglw0zSg9FI8MVidZL5c9lV5 s/FMukZGWF0HtHf6Zz0EopRlc8mRPAW/C2QQk= MIME-Version: 1.0 Received: by 10.229.7.137 with SMTP id d9mr4008738qcd.251.1310427379045; Mon, 11 Jul 2011 16:36:19 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.229.11.40 with HTTP; Mon, 11 Jul 2011 16:36:18 -0700 (PDT) In-Reply-To: References: <4E1421D9.7080808@zedat.fu-berlin.de> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <20110707015151.GB71966@troutmask.apl.washington.edu> <4E1B67C7.8040402@FreeBSD.org> Date: Mon, 11 Jul 2011 16:36:18 -0700 X-Google-Sender-Auth: WmDBoLs3p2k6wVW_t9_6IymblhA Message-ID: From: mdf@FreeBSD.org To: Ali Mashtizadeh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current , Arnaud Lacombe Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2011 23:36:20 -0000 On Mon, Jul 11, 2011 at 4:00 PM, Ali Mashtizadeh wr= ote: > Maybe someone can setup something like reviewboard [1] for developers > to use. This may also help folks who want to keep abreast of the > current work in a particular subsystem or get involved into the > development process more. At my company we use reviews and it seems to > help the catch some bugs and help new engineers ramp up faster. > > [1] http://www.reviewboard.org/ FreeBSD development is completely open; anyone can sign up for the svn-src-* mailing list they are interested in, including svn-src-head@. Code reviews are plenty as well; just check the list archives for discussion of bugs, poor design choices and unintended effects. But most reviews are silent and after-the-fact by looking at the list mail. It's a system that seems to be working just fine for the FreeBSD project so far. This isn't a job for most anyone; it's a volunteer project and so anything that raises the barrier to getting work done for the project should be looked at with skepticism. Is there a specific deficit that you want to address? Thanks, matthew > On Mon, Jul 11, 2011 at 2:48 PM, Arnaud Lacombe wrot= e: >> Hi, >> >> On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon wrote: >>> on 11/07/2011 23:33 Arnaud Lacombe said the following: >>>> For the record, I would like to see enforced public review for _every_ >>>> patch *before* it is checked in, as a strong rule. gcc system is >>>> particularly interesting. But it is not likely to happen in FreeBSD >>>> where FreeBSD committers are clearly more free than other at >>>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >>>> >>>> This would of course apply even to long-time committers, no matter how >>>> it hurt their ego (which I definitively do not care about). >>> >>> Have you just volunteered to review all of the patches that I would lik= e to >>> commit? =A0And are you prepared to take responsibility for quality of y= our reviews? >>> I am sure that other developers will gladly accept your offer too. >>> >> _No-one_ can do all the reviews, especially not me (on a purely >> technical level). ACK must come from subsystem maintainers. Having >> public review would allow the community review, which is now just not >> possible today. As about patches from the maintainer, they might be >> committed without his approval, but still sent for review. If a >> maintainer goes outside his area, he has to get approval from the >> other subsystem maintainer. >> >> =A0- Arnaud >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.or= g" >> > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >