From owner-cvs-all Mon Aug 9 1:27:18 1999 Delivered-To: cvs-all@freebsd.org Received: from gaia.euronet.nl (gaia.euronet.nl [194.134.0.10]) by hub.freebsd.org (Postfix) with ESMTP id 4C55215189; Mon, 9 Aug 1999 01:27:06 -0700 (PDT) (envelope-from marcel@scc.nl) Received: from mail.scc.nl (i323.ztm.euronet.nl [194.134.67.84]) by gaia.euronet.nl (8.8.8/8.8.8) with ESMTP id KAA19408; Mon, 9 Aug 1999 10:25:18 +0200 (MET DST) Received: from scc.nl (scones.sup.scc.nl [192.168.2.4]) by mail.scc.nl (8.9.3/8.9.3) with ESMTP id KAA33263; Mon, 9 Aug 1999 10:24:45 +0200 (CEST) (envelope-from marcel@scc.nl) Message-ID: <37AE904D.BBF20CB7@scc.nl> Date: Mon, 09 Aug 1999 10:24:45 +0200 From: Marcel Moolenaar Organization: SCC vof X-Mailer: Mozilla 4.61 [en] (X11; I; FreeBSD 4.0-CURRENT i386) X-Accept-Language: en MIME-Version: 1.0 To: "Brian F. Feldman" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/linux linux_misc.c References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Brian F. Feldman" wrote: > > On Sun, 8 Aug 1999, Marcel Moolenaar wrote: > > > marcel 1999/08/08 04:26:48 PDT > > > > Modified files: > > sys/i386/linux linux_misc.c > > Log: > > Fix page fault in linux_uselib syscall. > > Actually, this is bogus. As per the latest change to linux_util.h, > we actually check for an EFAULT from the copyinstr in CHECKALT*(). > You may as well leave this commit in place, but it is redundant. There's a big difference between bogus and redundant, but the question really is if the fix is correct or not? -- Marcel Moolenaar mailto:marcel@scc.nl SCC Internetworking & Databases http://www.scc.nl/ Amsterdam, The Netherlands tel: +31 20 4200655 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message