From owner-svn-src-head@freebsd.org Sat Sep 26 07:36:45 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DFC4A0807B; Sat, 26 Sep 2015 07:36:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EB1A47E7; Sat, 26 Sep 2015 07:36:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t8Q7ackT062588 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 26 Sep 2015 10:36:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t8Q7ackT062588 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t8Q7acAd062587; Sat, 26 Sep 2015 10:36:38 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 26 Sep 2015 10:36:38 +0300 From: Konstantin Belousov To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288258 - head/sys/sys Message-ID: <20150926073638.GS67105@kib.kiev.ua> References: <201509260730.t8Q7UjsJ019502@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201509260730.t8Q7UjsJ019502@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 07:36:45 -0000 On Sat, Sep 26, 2015 at 07:30:45AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Sat Sep 26 07:30:45 2015 > New Revision: 288258 > URL: https://svnweb.freebsd.org/changeset/base/288258 > > Log: > Make the __bitcount*() functions unconditionally available, by moving > them out of the #if _BSD_VISIBLE block. Other headers may depend on > __bitcount(). The dependencies can be a header not specified by > POSIX, and then namespace restrictions by _XOPEN_SOURCE are not > applicable, as it was reported. Or, we might grow an implementation > of some POSIX facility using __bitcount(), which also should work. It was ought to be mentioned in the commit message that all symbols moved out of the _BSD_VISIBLE protection are in the implementation-private namespace. In other words, by making the symbols declared unconditionally, we are still compliant.