From owner-freebsd-isp Sun May 5 21:57:33 1996 Return-Path: owner-isp Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id VAA08550 for isp-outgoing; Sun, 5 May 1996 21:57:33 -0700 (PDT) Received: from post.io.org (post.io.org [198.133.36.6]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id VAA08545 for ; Sun, 5 May 1996 21:57:31 -0700 (PDT) Received: from zot.io.org (taob@zot.io.org [198.133.36.82]) by post.io.org (8.7.5/8.7.3) with SMTP id AAA28593; Mon, 6 May 1996 00:58:58 -0400 (EDT) Date: Mon, 6 May 1996 00:56:28 -0400 (EDT) From: Brian Tao To: Dror Matalon cc: FREEBSD-ISP-L Subject: Re: Any inn1.4unoff4 on 2.1R caveats? In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-isp@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sun, 5 May 1996, Dror Matalon wrote: > > The following Perl script finds problems in your history files and fixes > them. THe comments indicate how to use.it. Use at your own risk. I ran the fixhist script this afternoon and it didn't find anything unusual. I traced the source of the segfault to the NGfind() routing in ng.c of innd. It's only a 6-line function that operates on the newsgroup hash table... I don't see anything in it that would all of a sudden cause segfaults at least once an hour. :( /* ** Hash a newsgroup and see if we get it. */ NEWSGROUP * NGfind(Name) char *Name; { register char *p; register int i; register unsigned int j; register NEWSGROUP **ngp; char c; NGHASH *htp; /* SUPPRESS 6 *//* Over/underflow from plus expression */ NGH_HASH(Name, p, j); htp = NGH_BUCKET(j); for (c = *Name, ngp = htp->Groups, i = htp->Used; --i >= 0; ngp++) if (c == ngp[0]->Name[0] && EQ(Name, ngp[0]->Name)) return ngp[0]; return NULL; } -- Brian Tao (BT300, taob@io.org, taob@ican.net) Systems and Network Administrator, Internet Canada Corp. "Though this be madness, yet there is method in't"