Date: Thu, 12 Dec 2019 15:45:51 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355609 - head Message-ID: <121c13a3-c855-049e-9137-e893d66759b1@FreeBSD.org> In-Reply-To: <201912111454.xBBEsT42073427@repo.freebsd.org> References: <201912111454.xBBEsT42073427@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SflHKJ1Ws9mAMVrUW3WG80ese46dADtiJ Content-Type: multipart/mixed; boundary="PxYM46VrNrNjcK1qFAtg7y4Dimf9FwlnZ"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <121c13a3-c855-049e-9137-e893d66759b1@FreeBSD.org> Subject: Re: svn commit: r355609 - head References: <201912111454.xBBEsT42073427@repo.freebsd.org> In-Reply-To: <201912111454.xBBEsT42073427@repo.freebsd.org> --PxYM46VrNrNjcK1qFAtg7y4Dimf9FwlnZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/11/2019 6:54 AM, Ed Maste wrote: > Author: emaste > Date: Wed Dec 11 14:54:29 2019 > New Revision: 355609 > URL: https://svnweb.freebsd.org/changeset/base/355609 >=20 > Log: > Make NOCLEAN an error instead of a warning > =20 > The warning was added in r289728 (over four years ago) and at that ti= me > NO_CLEAN was already the correct spelling for over a decade. > =20 > Make NOCLEAN an error as the next step to removing these backward > compatibility shims. >=20 > Modified: > head/Makefile.inc1 >=20 > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.inc1 Wed Dec 11 14:28:13 2019 (r355608) > +++ head/Makefile.inc1 Wed Dec 11 14:54:29 2019 (r355609) > @@ -458,8 +458,7 @@ SUBDIR+=3Detc > .endif # !empty(SUBDIR_OVERRIDE) > =20 > .if defined(NOCLEAN) > -.warning NOCLEAN option is deprecated. Use NO_CLEAN instead. > -NO_CLEAN=3D ${NOCLEAN} > +.error NOCLEAN option is deprecated. Use NO_CLEAN instead. > .endif > .if defined(NO_CLEANDIR) > CLEANDIR=3D clean cleandepend >=20 What ever happened to POLA? Name 1 good reason this should be an .error?! Or even a .warning for that matter. The argument I keep hearing is "we have to maintain these 3 lines of code", ok, well now it's just an annoyance to maintain with no benefit to the user. --=20 Regards, Bryan Drewery --PxYM46VrNrNjcK1qFAtg7y4Dimf9FwlnZ-- --SflHKJ1Ws9mAMVrUW3WG80ese46dADtiJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl3y0TVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l88q6Qf9HMa21ajY72nqMe2wsDIaUQlU1PoBd28LWBR8azV0au8Dohyj1iIvYZBi p2SmRoohDCAXdwgsmBhnIj9Y7HtBZo5l34VWyB/SFiFXd+9QOBMf8VinX7heb3tB QFskygRM9gb/U12pQDEKqHzFEgotxHwuBnWhQJ4HElY0+FU1LUlfI8fErK0ekz7I yZCw12R4KpmFpOX0f6oDts20gWkbHohjeGi2jlsiKrf6dsbm8WX1IIVeyA9rPtIM P5LWpb7MHPpVYHDMZo1KdVrUHVfktVhHIQTbh7Jnkb1Ob3lKnVtCk0kKo9y79RMr hdnDLjIqy4SPIwTQwZ0JiAcBHQG34Q== =CGV/ -----END PGP SIGNATURE----- --SflHKJ1Ws9mAMVrUW3WG80ese46dADtiJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?121c13a3-c855-049e-9137-e893d66759b1>