From owner-svn-src-head@FreeBSD.ORG Sat Aug 24 16:25:22 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 754C1759; Sat, 24 Aug 2013 16:25:22 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-x236.google.com (mail-ee0-x236.google.com [IPv6:2a00:1450:4013:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A74A726BA; Sat, 24 Aug 2013 16:25:21 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id e53so834890eek.27 for ; Sat, 24 Aug 2013 09:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=keUAZ7OkC7OOUmCshc7cLZGLf9NFPknDj2Kub8MPt8g=; b=rlWa6GARYzNVOt/sTbEWWgYvCnNhe9acApqft4okOTZ2/HOOEUbt83AwFmXKV4Ufto yAHEvZ/e9B5m+IwPK8RCnAf3A87wXNXL9Q0RVu7QfBW17N/b/JbEzwl2mVObZxe5jSni BZP4hdoPDdpErV+pJM3N8g+upRhzPAuvX1K/v8Vfnx46MgJR/maIv7h57lF1NGxv9Pxr gvLmet4+imK1WTdgXydNBgX4Ik1knbLtCVHrwaQf4lDKteV8HTKmf3XOUxiYmMtYtMsA Q5xGv0JC/Pff/8uLQ5Iymepgwqwr95OavLftRO8v9cAfVh95XOAg+ZSIMZY8EqZ6iYJT XiuA== X-Received: by 10.14.223.1 with SMTP id u1mr9217095eep.10.1377361519898; Sat, 24 Aug 2013 09:25:19 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([37.229.21.195]) by mx.google.com with ESMTPSA id i1sm7831492eeg.0.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 24 Aug 2013 09:25:18 -0700 (PDT) Sender: Alexander Motin Message-ID: <5218DE6C.4060700@FreeBSD.org> Date: Sat, 24 Aug 2013 19:25:16 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130616 Thunderbird/17.0.6 MIME-Version: 1.0 To: Dmitry Morozovsky Subject: Re: svn commit: r254787 - head/sys/kern References: <201308241441.r7OEfnFx060671@svn.freebsd.org> <5218D22F.8000009@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 16:25:22 -0000 On 24.08.2013 19:11, Dmitry Morozovsky wrote: > On Sat, 24 Aug 2013, Alexander Motin wrote: > >>>> MFprojects/camlock r254460: >>>> Remove locking from taskqueue_member(). The list of threads is static >>>> during the taskqueue life cycle, so there is no need to protect it, >>>> taking quite congested lock several more times for each ZFS I/O. >>> >>> Great, thanks! >>> >>> Any chances to MFC this to 9? >> >> I don't see any problem to do it after some time. > > Ah, so IIUC, it does not depend on other changes and could be tested on stock > stable/9 right now? If so, I'd merge this to our tinderbox/poudriere builder > and test. Yes, it is completely independent. Please, welcome. I am just not sure whether you notice much difference unless you have really a lot of IOPS. On my tests doing 90K IOPS over bunch of SSDs I've measured difference of several percents. -- Alexander Motin