From owner-freebsd-net@FreeBSD.ORG  Mon Feb 20 11:15:59 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E7A7116A420
	for <freebsd-net@freebsd.org>; Mon, 20 Feb 2006 11:15:59 +0000 (GMT)
	(envelope-from jinmei@isl.rdc.toshiba.co.jp)
Received: from shuttle.wide.toshiba.co.jp (shuttle.wide.toshiba.co.jp
	[202.249.10.124])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2607F43D5E
	for <freebsd-net@freebsd.org>; Mon, 20 Feb 2006 11:15:58 +0000 (GMT)
	(envelope-from jinmei@isl.rdc.toshiba.co.jp)
Received: from impact.jinmei.org (unknown [2001:200:0:8002:20e:7bff:fedd:fe03])
	by shuttle.wide.toshiba.co.jp (Postfix) with ESMTP
	id DCC0015218; Mon, 20 Feb 2006 20:15:57 +0900 (JST)
Date: Mon, 20 Feb 2006 20:15:57 +0900
Message-ID: <y7v4q2u1dsi.wl%jinmei@isl.rdc.toshiba.co.jp>
From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?=
	<jinmei@isl.rdc.toshiba.co.jp>
To: Craig Boston <craig@olyun.gank.org>
In-Reply-To: <20060127020528.GA18728@nowhere>
References: <20060125152032.GA40581@nowhere> <20060127020528.GA18728@nowhere>
User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI)
Organization: Research & Development Center, Toshiba Corp., Kawasaki, Japan.
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: freebsd-net@freebsd.org
Subject: Re: Race condition in ip6_getpmtu (actually gif)?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Feb 2006 11:16:00 -0000

>>>>> On Thu, 26 Jan 2006 20:05:28 -0600, 
>>>>> Craig Boston <craig@olyun.gank.org> said:

>> I seem to be running into a race condition in ip6_getpmtu.  I've been
>> having sporadic panics recently -- sometimes the machine will last a
>> week, sometimes it'll panic twice in a day.  The backtrace is always the
>> same:

(snip)

> Attached is a quick hack to protect the cached route with a mutex.  A
> better fix with less overhead would be to allocate the route in a local
> variable on the stack, and only copy it to the softc if route caching is
> enabled.  I'll run for a couple weeks with the patch and file a PR if
> that fixes it.

I guess this problem was fixed with the following changes:

http://www.jp.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_gif.c.diff?r1=1.57&r2=1.58
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_gif.c.diff?r1=1.23&r2=1.24

But I'll be happy to look at the problem more closely if not.

					JINMEI, Tatuya
					Communication Platform Lab.
					Corporate R&D Center, Toshiba Corp.
					jinmei@isl.rdc.toshiba.co.jp