From owner-freebsd-net  Tue Mar 27  9:22:49 2001
Delivered-To: freebsd-net@freebsd.org
Received: from mail-blue.research.att.com (mail-blue.research.att.com [135.207.30.102])
	by hub.freebsd.org (Postfix) with ESMTP id 522B037B719
	for <net@freebsd.org>; Tue, 27 Mar 2001 09:22:44 -0800 (PST)
	(envelope-from fenner@research.att.com)
Received: from alliance.research.att.com (alliance.research.att.com [135.207.26.26])
	by mail-blue.research.att.com (Postfix) with ESMTP
	id 0A5F24CE13; Tue, 27 Mar 2001 12:22:40 -0500 (EST)
Received: from windsor.research.att.com (windsor.research.att.com [135.207.26.46])
	by alliance.research.att.com (8.8.7/8.8.7) with ESMTP id MAA08770;
	Tue, 27 Mar 2001 12:22:39 -0500 (EST)
From: Bill Fenner <fenner@research.att.com>
Received: (from fenner@localhost)
	by windsor.research.att.com (8.8.8+Sun/8.8.5) id LAA23857;
	Tue, 27 Mar 2001 11:22:38 -0600 (CST)
Message-Id: <200103271722.LAA23857@windsor.research.att.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
To: jlemon@flugsvamp.com
Subject: Re: 4.3 issue: new ICMP handling broke date(1)
Cc: jesper@skriver.dk, asmodai@wxs.nl, net@freebsd.org
References:  <200103261557.JAA08568@windsor.research.att.com> <20010327124531.O68667@daemon.ninth-circle.org> <20010327131246.A71551@skriver.dk> <20010327101922.N93687@prism.flugsvamp.com> <20010327183646.A75484@skriver.dk> <20010327104826.P93687@prism.flugsvamp.com>
Date: Tue, 27 Mar 2001 11:22:38 -0600
Versions: dmail (solaris) 2.2g/makemail 2.9a
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


I prefer Jesper's other patch (the one that goes back to
code = PRC_UNREACH_PORT).  Note that the comment here:

                        /*
                         * RFC 1122, Sections 3.2.2.1 and 4.2.3.9.
                         * Treat subcodes 2,3 as immediate RST
                         */
                        case ICMP_UNREACH_PROTOCOL:
                        case ICMP_UNREACH_PORT:
                                code = PRC_UNREACH_ADMIN_PROHIB;
                                break;

3.2.2.1 says that ICMP errors must be passed to the transport layer,
and 4.2.3.9 is TCP-specific.  To me, it's a more general solution to
give the transport layer more specific info (i.e. code = PRC_UNREACH_PORT)
and let it act appropriately (i.e. TCP treats PRC_UNREACH_PORT specially),
especially since TCP and UDP may want to report different things here.

  Bill

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message