From owner-freebsd-bugs@freebsd.org  Wed Sep  9 15:15:26 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE374A00D48
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed,  9 Sep 2015 15:15:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DA9531C1B
 for <freebsd-bugs@FreeBSD.org>; Wed,  9 Sep 2015 15:15:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t89FFQDW034157
 for <freebsd-bugs@FreeBSD.org>; Wed, 9 Sep 2015 15:15:26 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 202996] pfctl: unitialized variable level in pfctl_set_debug
Date: Wed, 09 Sep 2015 15:15:26 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.2-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: andrej.kolontai@verwaltung.uni-muenchen.de
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-202996-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Sep 2015 15:15:27 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202996

            Bug ID: 202996
           Summary: pfctl: unitialized variable level in pfctl_set_debug
           Product: Base System
           Version: 10.2-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: andrej.kolontai@verwaltung.uni-muenchen.de

In pfctl.c, there is a function named pfctl_set_debug. 

The variable "level" in that function is declared but not initialized and used
in 

if (ioctl(dev, DIOCSETDEBUG, &level))

This can effectively set the pf debug level to loud (in my case it always does)
causing lots of messages on the console and syslog while the ruleset is loaded. 

In my case, this seems to have a serious impact on performance. 

I've made a patch:

--- /home/kolontai/pfctl.c    2015-09-09 17:11:05.016276000 +0200
+++ pfctl.c    2015-09-09 15:37:05.849986000 +0200
@@ -1845,6 +1845,8 @@
     }

     pf->debug_set = 1;
+    level = pf->debug;
+

     if ((pf->opts & PF_OPT_NOACTION) == 0)
         if (ioctl(dev, DIOCSETDEBUG, &level))

-- 
You are receiving this mail because:
You are the assignee for the bug.