From owner-freebsd-arm@FreeBSD.ORG  Wed Feb 25 22:45:12 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AFF00ED5
 for <freebsd-arm@freebsd.org>; Wed, 25 Feb 2015 22:45:12 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8CDD37D1
 for <freebsd-arm@freebsd.org>; Wed, 25 Feb 2015 22:45:12 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1PMjCh6016079
 for <freebsd-arm@freebsd.org>; Wed, 25 Feb 2015 22:45:12 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1PMjCo6016078;
 Wed, 25 Feb 2015 22:45:12 GMT (envelope-from root)
Date: Wed, 25 Feb 2015 22:45:12 +0000
To: freebsd-arm@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Changed Subscribers] D1967: Attempt to make
 libcxxrt's dwarf_eh work with strict alignment
Message-ID: <a4e789ede0b4e86a5043ce0bcc762122@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1967: Attempt to make libcxxrt's dwarf_eh work with strict
 alignment
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-5dahex5ejhfmjb6awx4r>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-pjrg7uwimqcazthartyl>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-fv5etkxckwkblyrnrb6f>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-2dch6afcj5u7ayk2c67t-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-2dch6afcj5u7ayk2c67t-req@FreeBSD.org>
Thread-Index: OWI2ZDlhM2EzZjk0NzYzNDhlNmU2YmYxZmFmIFTuUHg=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-cc>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2015 22:45:12 -0000

imp added a subscriber: imp.
imp added a comment.

I'd just do a memcpy version of the read routines. All this #ifdef junk is insane. It will do the right thing every time.

INLINE COMMENTS
  contrib/libcxxrt/dwarf_eh.h:154-163 uint16_t res;
  memcpy(&res, reinterpret_cast<void *>(*data), sizeof(uint16_)t);
  
  would be better.
  contrib/libcxxrt/dwarf_eh.h:176-188 see above for less insane code.
  contrib/libcxxrt/dwarf_eh.h:200-221 see above for less insane code.

REVISION DETAIL
  https://reviews.freebsd.org/D1967

To: dim, andrew, bapt, ian, theraven
Cc: imp, emaste, freebsd-arm