Date: Sat, 2 Apr 2011 01:11:58 +0200 (CEST) From: Philippe Pepiot <phil@philpep.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: bapt@FreeBSD.org Subject: ports/156118: [PATCH] devel/cgit bad variable substitution in plist Message-ID: <201104012311.p31NBwGe068181@diophante.philpep.org> Resent-Message-ID: <201104012330.p31NUBar079040@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156118
>Category: ports
>Synopsis: [PATCH] devel/cgit bad variable substitution in plist
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Apr 01 23:30:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Philippe Pepiot
>Release: FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD diophante.philpep.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
%%PORTNAME%% is used in pkg-plist and pkg-message files and isn't substitued, see SUB_LIST in bsd.port.mk
>How-To-Repeat:
See %PORTNAME% in +CONTENT file, and if you install package with pkg_add it will create /var/cache/%PORTNAME% :)
>Fix:
Proposal fix, but you maybe can do something like SUB_LIST+= PORTNAME=${PORTNAME} in Makefile.
--- cgit.patch begins here ---
diff -ru cgit.orig/files/pkg-message.in cgit/files/pkg-message.in
--- cgit.orig/files/pkg-message.in 2008-10-16 13:26:36.000000000 +0200
+++ cgit/files/pkg-message.in 2011-04-02 00:53:49.492001592 +0200
@@ -1,5 +1,5 @@
---------------------------------------------------
-%%PORTNAME%% has been successfully installed.
+cgit has been successfully installed.
Now you need to change your webserver configuration
as follows:
diff -ru cgit.orig/pkg-plist cgit/pkg-plist
--- cgit.orig/pkg-plist 2011-03-12 03:03:19.215946000 +0100
+++ cgit/pkg-plist 2011-04-02 00:53:18.604363588 +0200
@@ -8,5 +8,5 @@
@dirrm lib/cgit/filters
@dirrm lib/cgit
@dirrm %%WWWDIR%%
-@exec mkdir -p /var/cache/%%PORTNAME%%
-@unexec rmdir /var/cache/%%PORTNAME%% 2>/dev/null || true
+@exec mkdir -p /var/cache/cgit
+@unexec rmdir /var/cache/cgit 2>/dev/null || true
--- cgit.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104012311.p31NBwGe068181>